Skip to content

Put file metrics in xml output - #7547

Merged
danmar merged 8 commits into
cppcheck-opensource:mainfrom
ludviggunne:metrics-xml
Jun 2, 2025
Merged

Put file metrics in xml output#7547
danmar merged 8 commits into
cppcheck-opensource:mainfrom
ludviggunne:metrics-xml

Conversation

@ludviggunne

@ludviggunneludviggunne commented May 25, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Comment threadlib/cppcheck.h Outdated
Comment threadlib/cppcheck.h Outdated
@danmar

Copy link
Copy Markdown
Collaborator

"params": { "comments": 42, "statements": 62 }

let's assume for now that there will only be a "value": 123
we can report comments and statements as 2 separate metrics.

@ludviggunne
ludviggunneforce-pushed the metrics-xml branch 6 times, most recently from 3908d27 to 6503074CompareMay 29, 2025 09:17
Comment threadcli/cppcheckexecutor.cpp Outdated
@ludviggunne
ludviggunneforce-pushed the metrics-xml branch 5 times, most recently from 9c9b519 to 6d29281CompareMay 30, 2025 12:45
Comment threadlib/cppcheck.cpp Outdated
Comment threadlib/cppcheck.cpp Outdated
@ludviggunne
ludviggunne marked this pull request as ready for review May 31, 2025 17:49
Comment threadtest/cli/metrics_test/dummy_addon.py Outdated
@danmar
danmar merged commit 51f6d91 into cppcheck-opensource:mainJun 2, 2025
@ludviggunne
ludviggunne deleted the metrics-xml branch June 2, 2025 10:04
@firewave

Copy link
Copy Markdown
Collaborator

The *.ts files should have been omitted from this.

And the newly added Python tests fail with #7079 applied. I have not looked into it as there is still a dozen other issues.

@ludviggunne

ludviggunne commented Jun 3, 2025

Copy link
Copy Markdown
CollaboratorAuthor

The *.ts files should have been omitted from this.

I could revert those files?

...still a dozen other issues.

Are you tlaking about issues in this PR?

@firewave

Copy link
Copy Markdown
Collaborator

The *.ts files should have been omitted from this.

I could revert those files?

No need.

...still a dozen other issues.

Are you tlaking about issues in this PR?

No, I was referring to #7079.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ludviggunne@danmar@firewave