Uh oh!
There was an error while loading. Please reload this page.
fixed #13909 / refs #13914 - some (enforced) language handling fixes for the GUI - #7570
Conversation
f85cc26 to
2b9d467Compare
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading. Please reload this page.
firewave
commented
Jun 15, 2025
This makes me wonder if markup files are handled properly in the GUI. But not something to explicitly look into as it should be implicitly be fixed as we move towards the shared executor code. |
This comment was marked as resolved.
This comment was marked as resolved.
4827e62 to
3c799bcComparefirewave
commented
Jun 22, 2025
I will fix the remaining TODOs in a follow-up coming later today. This needs to be fixed because it causes assertions whereas the other issues are "just" causing unexpected behavior. |
| ifndef INCLUDE_FOR_TEST | ||
| INCLUDE_FOR_TEST=-Ilib -Icli -isystem externals/simplecpp -isystem externals/tinyxml2 | ||
| INCLUDE_FOR_TEST=-Ilib -Ifrontend -Icli -isystem externals/simplecpp -isystem externals/tinyxml2 |
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options --addon=naming.json cli frontend || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options --addon=naming.json frontend || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options --addon=naming.json -Ifrontend cli || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options --addon=naming.json --enable=internal lib || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options -DQT_VERSION=0x060000 -DQ_MOC_OUTPUT_REVISION=69 -DQT_CHARTS_LIB -DQT_MOC_HAS_STRINGDATA --library=qt --addon=naming.json -Icmake.output/gui -Igui gui/*.cpp cmake.output/gui/*.cpp || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options -Icli test/*.cpp tools/dmake/*.cpp || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options -DQT_VERSION=0x060000 -DQ_MOC_OUTPUT_REVISION=69 -DQT_CHARTS_LIB -DQT_MOC_HAS_STRINGDATA --library=qt --addon=naming.json -Icmake.output/gui -Ifrontend -Igui gui/*.cpp cmake.output/gui/*.cpp || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options -Icli -Ifrontend test/*.cpp || ec=1 | ||
| ./cmake.output/bin/cppcheck $selfcheck_options $cppcheck_options -Icli tools/dmake/*.cpp || ec=1 |
There was a problem hiding this comment.
More stuff which was not considered in #7579.
firewave
commented
Jun 23, 2025
Turns out the remaining cases are a bit more complicated... |
@firewave I have a question, I hope you can help me since you've been looking at the language handling. I built a devdrop for a customer at June 2nd using the latest Cppcheck source code at that time. The devdrop reports such syntax errors: I believe the customer uses the GUI mostly. Do you know if we've had some bug in the language handling that was fixed lately? The latest Cppcheck release works fine. |
firewave
commented
Jun 23, 2025
I think was a side effect of the language not being applied. It appears to be the same issue Robert reported in https://trac.cppcheck.net/ticket/13909. I did several manual tests with the GUI yesterday and everything was working as expected - with files and projects. Except for applying the enforced language when scanning files and not a project. |
danmar
commented
Jun 23, 2025
Thanks! |
… in `getBufferSize()`
…()` (#7767) Detect address-of token in `getBufferSize()` and get the underlying variable's corresponding buffer size. `stringNotZeroTerminated()` also calls `getBuffersize()`, so it will also benefit.
No description provided.