refs #13698 - exit early in Library::detect*() if token is a keyword

[firewave]

No description provided.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[firewave]

Encountered while looking into https://trac.cppcheck.net/ticket/12861 which does not contain any non-keyword types.

Running that code with DISABLE_VALUEFLOW=1
620,494,011-> 560,704,707

Reduction of actual lookups in the affected calls
Library::detectContainerInternal()- 262,190 -> 26
Library::detectSmartPointer()- 65,548 -> 7

Callgrind in CI
57,705,030,015-> 56,431,293,618

[firewave]

No differences with #7800.

[chrchr-github]

Are there other types of token that it's worth bailing out for?

[firewave]

Most likely, but I only went by profiling results (there's more improvements coming from the sample in question). See also #7373.