Uh oh!
There was an error while loading. Please reload this page.
fixed #13388 - store active checkers in build dir - #7852
Merged
Conversation
firewaveforce-pushed
the
builddir-checkers
branch
from
September 25, 2025 07:27
d2d6623 to
4907ae7Comparefirewave
commented
Sep 25, 2025
CollaboratorAuthor
No test has been added since it is tested via the |
firewave
marked this pull request as ready for review
September 25, 2025 07:29
firewaveforce-pushed
the
builddir-checkers
branch
from
September 25, 2025 07:41
4907ae7 to
711d3d5Comparefirewave
commented
Sep 25, 2025
Comment on lines
+326
to
+330
| // cppcheck-suppress accessMoved - FP | ||
| while (std::getline(fout, line)) | ||
| { | ||
| // cppcheck-suppress accessMoved - FP | ||
| activeCheckers.emplace(std::move(line)); |
CollaboratorAuthor
There was a problem hiding this comment.
This code was copied and the false positives are already being tracked in https://trac.cppcheck.net/ticket/11300.
danmar
reviewed
Sep 27, 2025
danmar
left a comment
Collaborator
There was a problem hiding this comment.
👍 I am happy with this if the ifstream object is renamed to fin.
| if (mCheckersFile.empty()) | ||
| return; | ||
| std::ifstream fout(mCheckersFile); |
firewaveforce-pushed
the
builddir-checkers
branch
from
September 29, 2025 00:24
711d3d5 to
6e78f7bCompare
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.