Fix #14433 (Import project: refactor code to read compile_commands.json) by ludviggunne · Pull Request #8030 · cppcheck-opensource/cppcheck

ludviggunne · 2025-12-12T12:18:51Z

There has been multiple issues with the import lately, and (my) fixes have been a bit hacky. With this change, command is first split similarily to how the shell would, and is then handled like the arguments field. For extracting compiler options, the argument list is handled like the compiler would read argv. I believe this will be easier to maintain in the future.

chrchr-github · 2025-12-12T15:20:30Z

The clang-tidy warning seems to be a false positive, I have reported it here: llvm/llvm-project#172018

danmar

I have not checked it in detail yet but this is better approach in my opinion. 👍

I feel we shouldn't merge this before the release though it could introduce some bug.

danmar · 2026-01-12T15:55:58Z

 - name: Self check (unusedFunction / no test / no gui)
 run: |
- supprs="--suppress=unusedFunction:lib/errorlogger.h:196 --suppress=unusedFunction:lib/importproject.cpp:1516 --suppress=unusedFunction:lib/importproject.cpp:1540"
+ supprs="--suppress=unusedFunction:lib/errorlogger.h:196 --suppress=unusedFunction:lib/importproject.cpp:1515 --suppress=unusedFunction:lib/importproject.cpp:1539"


@firewave it feels like inline suppressions should be used instead. why don't we? my spontanous guess is that different selfchecks generate different warnings?

@firewave or how about adding maybe_unused attributes to the functions?

danmar

some more small nits. overall this PR makes the code much cleaner imho and I envision it will be more robust thanks to that.

sonarqubecloud · 2026-01-24T17:51:11Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 3792859 to 7941aaeCompare December 12, 2025 13:10

danmar reviewed Dec 14, 2025
View reviewed changes

ludviggunne force-pushed the cdb-parse-rewrite branch 3 times, most recently from 5fbb9e0 to b6c9031Compare December 14, 2025 23:18

chrchr-github added the merge-after-next-release Wait with merging this PR until after the next Release label Dec 15, 2025

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 0e066dd to a9fd6d4Compare December 17, 2025 11:56

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 8e36982 to 20ac362Compare December 28, 2025 14:55

danmar reviewed Jan 2, 2026
View reviewed changes

Comment threadlib/importproject.cpp Outdated
Comment threadlib/importproject.cpp Outdated
Comment threadlib/importproject.cpp
Comment threadlib/importproject.cpp Outdated

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 7c73ad4 to fb2e7b3Compare January 3, 2026 13:04

danmar reviewed Jan 6, 2026
View reviewed changes

Comment threadlib/importproject.cpp Outdated
Comment threadlib/importproject.cpp Outdated
Comment threadlib/importproject.cpp Outdated

ludviggunne force-pushed the cdb-parse-rewrite branch from fb2e7b3 to a203adaCompare January 6, 2026 18:51

github-advanced-securityAI found potential problems Jan 6, 2026
View reviewed changes

Comment threadlib/importproject.cpp Fixed

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 4fb1d36 to 63dae98Compare January 11, 2026 18:16

danmar reviewed Jan 12, 2026
View reviewed changes

danmar reviewed Jan 20, 2026
View reviewed changes

Comment threadlib/importproject.cpp Outdated
Comment threadlib/importproject.cpp Outdated
Comment threadlib/importproject.cpp Outdated

danmar reviewed Jan 20, 2026
View reviewed changes

Comment threadlib/importproject.cpp Outdated

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from 46445d7 to 48dd74cCompare January 20, 2026 15:02

ludviggunne added 5 commits January 20, 2026 16:50

Add ImportProject::collectArgs()
b757d8a

Add tests for ImportProject::collectArgs()
167706e

Add ImportProject::parseArgs()
e1902c8

Replace existing command parsing
3044e7b

Remove existing command parsing
e9227a1

ludviggunne added 2 commits January 20, 2026 16:50

Update suppression line numbers in selfcheck
f33fe3a

Add clang-tidy suppressions
55ac8b1

ludviggunne force-pushed the cdb-parse-rewrite branch 2 times, most recently from d3ce262 to f7ac10eCompare January 20, 2026 15:51

danmar reviewed Jan 21, 2026
View reviewed changes

Comment threadlib/importproject.cpp
Comment threadlib/importproject.cpp Outdated

ludviggunne added 2 commits January 24, 2026 18:29

Rewrite parseArgs
9cdf01b

Update selfcheck suppressions
33c4119

ludviggunne force-pushed the cdb-parse-rewrite branch from f7ac10e to 33c4119Compare January 24, 2026 17:44

danmar changed the title ~~Rework compile_commands.json import~~Fix #14433 (Import project: refactor code to read compile_commands.json)Jan 26, 2026

danmar merged commit ddce8d5 into cppcheck-opensource:mainJan 26, 2026
64 checks passed

ludviggunne deleted the cdb-parse-rewrite branch January 26, 2026 15:55

Uh oh!

Conversation

ludviggunne commented Dec 12, 2025

Uh oh!

chrchr-github commented Dec 12, 2025

Uh oh!

danmar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danmarJan 12, 2026

Choose a reason for hiding this comment

Uh oh!

danmarJan 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

danmar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloudBot commented Jan 24, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants