Uh oh!
There was an error while loading. Please reload this page.
refs #13810 - fixed missing column for invalidSuppression - #8121
Merged
Conversation
invalidSuppression
This comment was marked as resolved.
This comment was marked as resolved.
firewave
marked this pull request as draft
January 14, 2026 03:14
firewaveforce-pushed
the
inline-suppr-col
branch
from
January 14, 2026 03:15
bc10f98 to
c30d76bCompare
This comment was marked as resolved.
This comment was marked as resolved.
firewaveforce-pushed
the
inline-suppr-col
branch
2 times, most recently
from
February 27, 2026 14:13
919f285 to
ac60edeComparefirewave
marked this pull request as ready for review
February 27, 2026 14:13
danmar
previously approved these changes
Feb 27, 2026
danmar
left a comment
Collaborator
There was a problem hiding this comment.
I have a suggestion.. feel free to merge with or without that..
| std::list<ErrorMessage::FileLocation> callStack; | ||
| if (!s.fileName.empty()) { | ||
| callStack.emplace_back(s.fileName, s.lineNumber == -1 ? 0 : s.lineNumber, 0); // TODO: get rid of s.lineNumber == -1 hack | ||
| callStack.emplace_back(s.fileName, s.lineNumber == -1 ? 0 : s.lineNumber, 0); // TODO: set column - see #13810 / get rid of s.lineNumber == -1 hack |
Collaborator
There was a problem hiding this comment.
an option could be to replace -1 with Suppression::NO_LINE. I have no strong opinion.
CollaboratorAuthor
There was a problem hiding this comment.
Yes. I should have done that in the previous change. But I already have a local branch where it has been removed so it will not be overlooked in the future.
If it were to be overlooked it should be caught by the signedness comparison compiler warnings when lineNumber is finally unsigned but unfortunately we still have these disabled.
firewaveforce-pushed
the
inline-suppr-col
branch
from
February 27, 2026 15:54
ac60ede to
3564714Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.