Skip to content

fixed #13087 - store unmatchedSuppression in AnalyzerInformation - #8173

Merged
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:unmatched-ainfo
Feb 26, 2026
Merged

fixed #13087 - store unmatchedSuppression in AnalyzerInformation#8173
firewave merged 2 commits into
cppcheck-opensource:mainfrom
firewave:unmatched-ainfo

Conversation

@firewave

@firewavefirewave commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@firewave

This comment was marked as resolved.

Sign in to view
@firewave
firewaveforce-pushed the unmatched-ainfo branch 3 times, most recently from f94bc98 to 30ef794CompareJanuary 30, 2026 16:59
@firewave

firewave commented Jan 31, 2026

Copy link
Copy Markdown
CollaboratorAuthor

The code is quite horrible and not performant but it will only be executed when you encounter an unmatched suppression which should not be common.

This addresses a big chunk of the failures in #7079. After that has been merged and all the remaining suppression issues have been fixed we should be able to clean this up a bit.

@firewave
firewaveforce-pushed the unmatched-ainfo branch 2 times, most recently from 4f05a80 to 2c5ad2dCompareFebruary 10, 2026 17:07
github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 10, 2026
View reviewed changes
Comment threadlib/analyzerinfo.cpp Fixed
@firewave
firewaveforce-pushed the unmatched-ainfo branch 4 times, most recently from eaee792 to 236b811CompareFebruary 14, 2026 20:58
@firewave
firewave marked this pull request as ready for review February 14, 2026 21:21
@firewavefirewave mentioned this pull request Feb 25, 2026
Merged
danmar
danmar reviewed Feb 25, 2026
View reviewed changes
Comment threadcli/cppcheckexecutor.cpp Outdated
@firewave
firewaveforce-pushed the unmatched-ainfo branch 2 times, most recently from 6119b4e to 055fec6CompareFebruary 26, 2026 00:36
@firewave
firewave marked this pull request as draft February 26, 2026 01:40
@firewave

firewave commented Feb 26, 2026

Copy link
Copy Markdown
CollaboratorAuthor

I think this needs to addressed differently. Still looking into it.

@firewave

firewave commented Feb 26, 2026•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

I think this needs to addressed differently. Still looking into it.

This looks fine for now (using the test-driven approach) but I have a follow-up.

@firewave
firewave marked this pull request as ready for review February 26, 2026 02:04
@firewavefirewave mentioned this pull request Feb 26, 2026
Merged
danmar
danmar reviewed Feb 26, 2026
View reviewed changes

@danmardanmar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactorings

Comment threadcli/cppcheckexecutor.cpp Outdated
Comment threadcli/cppcheckexecutor.cpp Outdated
@sonarqubecloud

sonarqubecloudBot commented Feb 26, 2026

Copy link
Copy Markdown

Quality Gate PassedQuality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@firewave
firewave merged commit f04dccd into cppcheck-opensource:mainFeb 26, 2026
68 checks passed
@firewave
firewave deleted the unmatched-ainfo branch February 26, 2026 13:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmardanmardanmar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@firewave@danmar@github-advanced-security