Skip to content

Fix #11439 FP returnDanglingLifetime for assignment to global var#8777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 3 commits into
base:main
Choose a base branch
from
+11 −2
Open

Fix #11439 FP returnDanglingLifetime for assignment to global var #8777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36cf2df
Update vf_analyzers.cpp
chrchr-github Aug 5, 2026
aa4f867
Update testautovariables.cpp
chrchr-github Aug 5, 2026
07cb8ab
Update testautovariables.cpp
chrchr-github Aug 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/vf_analyzers.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -892,7 +892,7 @@ static bool isAliasOf(const Variable * var, const Token *tok, nonneg int varid,
return false;
if (val.isLifetimeValue() && !val.isLocalLifetimeValue())
return false;
if (val.isLifetimeValue() && val.lifetimeKind != ValueFlow::Value::LifetimeKind::Address)
if (val.isLifetimeValue() && val.lifetimeKind != ValueFlow::Value::LifetimeKind::Address && val.lifetimeKind != ValueFlow::Value::LifetimeKind::SubObject)
return false;
if (!Token::Match(val.tokvalue, ".|&|*|%var%"))
return false;
Expand DownExpand Up@@ -1167,7 +1167,7 @@ struct SingleValueFlowAnalyzer : ValueFlowAnalyzer {
}

bool isAlias(const Token* tok, bool& inconclusive) const override {
if (value.isLifetimeValue())
if (value.isLifetimeValue() && value.lifetimeKind != ValueFlow::Value::LifetimeKind::SubObject)
return false;
for (const auto& m: {
std::ref(getVars()), std::ref(getAliasedVars())
Expand Down
9 changes: 9 additions & 0 deletions test/testautovariables.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3240,6 +3240,15 @@ class TestAutoVariables : public TestFixture {
" return s[0].p.get();\n"
"}\n");
ASSERT_EQUALS("", errout_str());

check("std::unique_ptr<int> g_p;\n"// #14958
"int* f() {\n"
" std::unique_ptr<int> tmp = std::make_unique<int>();\n"
" int* p = tmp.get();\n"
" g_p = std::move(tmp);\n"
" return p;\n"
"}\n");
ASSERT_EQUALS("", errout_str());
}
voiddanglingLifetime() {
check("auto f() {\n"
Expand Down
Loading