Uh oh!
There was an error while loading. Please reload this page.
Use _WIN32 only to check for windows - #531
Closed
glankk wants to merge 1 commit into
Closed
Conversation
firewave
commented
Sep 2, 2025
Collaborator
Let's focus on #524 for now and leave the |
firewave
commented
Sep 2, 2025
Collaborator
And please mention the ticket it fixes in the title. |
danmar
commented
Sep 9, 2025
Collaborator
Yes.. in general it is better to use |
firewave
marked this pull request as draft
September 10, 2025 09:44
firewave
commented
Sep 12, 2025
Collaborator
I published #541 as a replacement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
__CYGWIN__and__MINGW32__checks, as well as theSIMPLECPP_WINDOWSmacro, in favor of_WIN32. Needed for #475.