Uh oh!
There was an error while loading. Please reload this page.
improved simplecpp::TokenList constructors - #599
Merged
Conversation
simplecpp::View to clean up simplecpp::TokenList constructorssimplecpp::View to clean up simplecpp::TokenList constructorsfirewaveforce-pushed
the
view
branch
2 times, most recently
from
December 8, 2025 01:45
789bda9 to
431c397Compare
This comment was marked as outdated.
This comment was marked as outdated.
simplecpp::View to clean up simplecpp::TokenList constructorssimplecpp::View to be able to write portable codefirewave
commented
Dec 8, 2025
CollaboratorAuthor
Required to address https://trac.cppcheck.net/ticket/14267. |
simplecpp::View to be able to write portable codesimplecpp::TokenList constructorsfirewave
commented
Dec 10, 2025
| { | ||
| std::vector<std::string> filenames; | ||
| { | ||
| char input[] = "code"; // NOLINT(misc-const-correctness) |
CollaboratorAuthor
There was a problem hiding this comment.
This is not actually reported but pre-emptively added in case it is detected in the future. I added a comment about it upstream: llvm/llvm-project#56758 (comment)
firewave
marked this pull request as ready for review
December 12, 2025 19:38
firewave
marked this pull request as draft
December 12, 2025 19:40
firewaveforce-pushed
the
view
branch
2 times, most recently
from
December 12, 2025 20:16
34d5cb3 to
27716f3Compare
This comment was marked as resolved.
This comment was marked as resolved.
firewaveforce-pushed
the
view
branch
2 times, most recently
from
December 14, 2025 23:39
0f5564d to
7e93e54Comparefirewave
commented
Dec 14, 2025
CollaboratorAuthor
We can tag 1.6.4 after this has been merged, |
…nList` code and added tests for all inputs
firewave
marked this pull request as ready for review
December 15, 2025 11:18
danmar
reviewed
Dec 15, 2025
Uh oh!
There was an error while loading. Please reload this page.
danmar
approved these changes
Dec 16, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplecpp::Viewto be able to write code which is compatible with C++11 and => C++17