Skip to content

feat(create-group): create group form - #20

Open
MinT-Napkin wants to merge 49 commits into
mainfrom
create-group-form
Open

feat(create-group): create group form#20
MinT-Napkin wants to merge 49 commits into
mainfrom
create-group-form

Conversation

@MinT-Napkin

Copy link
Copy Markdown
Contributor

Includes:

  • Dropdown component
  • TagInput component
  • ImagePicker dependency

Notes:

  • Currently commented out 'Flatlist' in the FeedScreen to test the create group form, but that change has not been committed.

- 4 screens, with the first screen used as the prompter/the screen to initiate the form. The 3 screens afterwards are the form itself
- Some fields are not finished but most text related fields have basic validation
@MinT-Napkin
MinT-Napkin marked this pull request as ready for review June 9, 2023 03:22
MinT-Napkinand others added 8 commits June 28, 2023 00:59
Still needs react context
Added GroupContext in order to retain information inputted by the user when moving in between screens of the Create Group Form, as well as remove the information when leaving the form.
Contains an error of 413 when you submit something in the group form
@nappalion
nappalion self-requested a review August 10, 2023 21:49

@nappalionnappalion left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the file name should use underscores or camel case "create_group_form". (kind of like node_modules)

Overall, all the base functionality works very well, and I love the use of GroupContext. The components "Dropdown" and "TagInput" will also be great for other parts of the app. As for styling, Luke mentioned we'd have a UI designer soon, so we can wait on changing any of the looks.

Comment threadpackages/app/screens/feed/create group form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create group form/CreateGroupFormScreen2.js Outdated
Comment threadpackages/app/screens/feed/create group form/CreateGroupFormScreen3.js Outdated
Comment threadpackages/server/controllers/guild.js Outdated
Comment threadpackages/server/routes/api/guild.js Outdated
Comment threadpackages/app/utils/GroupContext.js Outdated
Comment threadpackages/app/screens/feed/create group form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create group form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/components/Dropdown.js
@MinT-Napkin

Copy link
Copy Markdown
ContributorAuthor

note: on IOS the image picker doesn't work but I think the IOS build is based off of main without the expo image picker plugin. possible IOS rebuild after merging this branch

@MinT-Napkin

Copy link
Copy Markdown
ContributorAuthor

altered createGuild post request since insertGuild was very similar (insertGuild post request now deleted)

most of it should be the same except the createGuild code in the guilds file in the controllers folder

@MinT-Napkin

Copy link
Copy Markdown
ContributorAuthor

banner and icon variables in the guild object are also empty when creating a guild, not sure what to use them for

@lxkedinhlxkedinh left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good so far! There are just a few things that need to be fixed. Also, remember to look through your code and clean up any console logs and commented-out code for debugging since we don't want that in production code.

Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/components/TagInput.js
Comment threadpackages/app/components/Dropdown.js
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen2.js Outdated
Comment threadpackages/app/utils/GroupContext.js Outdated
Comment threadpackages/app/utils/GroupContext.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen1.js Outdated
Comment threadpackages/app/screens/feed/create_group_form/CreateGroupFormScreen2.js Outdated
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MinT-Napkin@lxkedinh@nappalion