This repository was archived by the owner on Jul 22, 2022. It is now read-only.
Add support for styling the tutorial popover - #37
Open
oubiwann wants to merge 4 commits into
Open
Conversation
cquanu
commented
Dec 21, 2016
Owner
@oubiwann Hi, thanks for helping! The infobar is already fixed in v2.6.0 release (Haven't push it). However, you can style the TutorialPopover but some color need to be changed. |
cquanu
commented
Dec 21, 2016
Owner
@oubiwann Can you try this color? Background: #1a2632, btn #243447 |
Also: * Moved `.TutorialPopover` into its own section * Removed `.branch-infobar`, since that work has been done already in a different branch
oubiwann
commented
Dec 24, 2016
Author
I've changed the background color; trying to figure out how to get the tutorial messages back so that I can test the button color ... |
oubiwann
commented
Dec 24, 2016
Author
Hrm, for the popovers and dropdowns, a caret is used. When the popover/dropdown background color is different from the page background, this caret (or wedge) is visiable; when Attaching screenshot:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the issue:
Tutorial popover wasn't getting styling treatment.
What's fixed:
Now it is :-)
Screenshots:
Before:
After:
