[5.x]: Replacing a field in a field layout does not update field conditions using that field

[MoritzLost]

What happened?

Description

When a field in a field layout is replaced, existing field conditions are not updated to point to the new field.

Steps to reproduce

1. Create an entry type with two fields field_a and field_b.
2. Add a visibility entry condition to field_b to only show up when field_a has a value.
3. Replace field_a with a new field (field_c).
4. In the field layout, field_a still has the diamond icon indicating a field condition. But opening the field doesn't show any field conditions.

Expected behavior

When a field is replaced, all field conditions in that field layout should be updated to reflect the change.

Actual behavior

See above.

Craft CMS version

5.10.14

PHP version

No response

Operating system and version

No response

Database type and version

No response

Image driver and version

No response

Installed plugins and versions

[linear-code]

CMS-2369

[brandonkelly]

Thanks for pointing that out.

This is a tricky one, so the best I could do is a partial fix (see #19515). And even the partial fix was pretty involved, so I’m targeting 5.11 for it.

[MoritzLost]

@brandonkelly Thanks for the fix! In the cases where the new field has a different condition rule class than the old field, it might make sense to delete the existing rules automatically? Since they won't work anymore anyway, and will get cleared out the next time the field instance is saved …

[brandonkelly]

Craft 5.11.0 is out with that fix.

In the cases where the new field has a different condition rule class than the old field, it might make sense to delete the existing rules automatically?

Maybe, but that would be more complicated, and with no practical benefit. We would only be able to do it on save, so it wouldn’t prevent those diamond icons from sticking around.