[6.x] Add Form-based plugin settings - #19439
Merged
Merged
Conversation
📚 Storybook previews@craftcms/ui — open Storybook No changed components detected in this Storybook. resources/js — open Storybook No changed components detected in this Storybook. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Form-based plugin settings pages while retaining Yii-era HTML compatibility.
Changes:
- Introduces
Plugin::settingsForm()and Inertia Form rendering. - Adapts legacy settings HTML and expands tests/documentation.
- Installs the test plugin in the workbench.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CHANGELOG.md |
Documents the settings API migration. |
composer.json |
Registers the test plugin package. |
composer.lock |
Locks the local test plugin. |
docs/forms.md |
Documents plugin settings Forms. |
resources/js/modules/plugin-manager/components/PluginLinks.vue |
Adds same-tab settings navigation. |
resources/templates/settings/plugins/_settings.twig |
Removes the legacy settings template. |
src/Plugin/Concerns/HasSettings.php |
Builds standard Inertia settings responses. |
tests/Feature/Http/Controllers/PluginsControllerTest.php |
Tests settings pages and overrides. |
tests/TestClasses/TestPlugin/composer.json |
Defines the test plugin package. |
tests/TestClasses/TestPlugin/src/TestPlugin.php |
Implements a test settings Form. |
tests/Unit/Form/ReplacementFormContractsTest.php |
Verifies removal of the HTML hook. |
workbench/database/seeders/DatabaseSeeder.php |
Installs the test plugin. |
yii2-adapter/legacy/base/Plugin.php |
Wraps legacy settings HTML in a Form. |
yii2-adapter/tests-laravel/Legacy/LegacyHtmlFormTest.php |
Tests legacy plugin settings capture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
riasvdv
marked this pull request as ready for review
August 15, 2026 09:24
riasvdv
marked this pull request as draft
August 15, 2026 09:24
riasvdv
marked this pull request as ready for review
August 15, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
Plugin::settingsForm()as the standard plugin settings UI, renders settings through the Inertia Form page, and keeps Yii-era HTML settings compatible through the adapter. Adds the test plugin to the workbench for manual verification.