[5.11] Ensure addresses are memoized when eager loaded

[nfourtythree]

Description

Similar to how authors on entires works, addresses should be memoized when eager loaded so there aren't any accidental extra queries if someone was to call getAddresses()

[Copilot]

Pull request overview

This PR memoizes user addresses during eager loading to avoid redundant queries and adds consistency coverage.

Changes:

• Caches eagerly loaded addresses on User.
• Adds tests for eager-loaded address consistency.
• Requires filtering to fieldId = null and preserving default id ASC ordering while allowing explicit ordering overrides.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Review
src/elements/User.php	Address eager loading has ordering and filtering inconsistencies with getAddresses().
tests/unit/elements/EagerLoadedElementConsistencyTest.php	Adds coverage for eager-loaded address behavior.

Suppressed comments (1)

tests/unit/elements/EagerLoadedElementConsistencyTest.php:222

• This fixture only creates unscoped addresses, so it cannot catch the field-address case introduced by this change. The eager-loading map is keyed by primaryOwnerId while getAddresses() filters on fieldId = null; add a field-owned address and assert that getAddresses() excludes it (and define whether that address should remain in getEagerLoadedElements('addresses')).

        $addressData = [
            [
                'id' => 9004,
                'countryCode' => 'US',
                'addressLine1' => '123 Main St',
                'administrativeArea' => 'CA',
                'locality' => 'Los Angeles',
                'postalCode' => '90001',
            ],
            [
                'id' => 9005,
                'countryCode' => 'US',
                'addressLine1' => '456 Elm St',
                'administrativeArea' => 'CA',
                'locality' => 'Los Angeles',
                'postalCode' => '90002',
            ],
        ];
        $addresses = array_map(fn($data) => new Address($data), $addressData);

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.