webauthn, userHandle and base64 encoding - #19536
Merged
Merged
Conversation
[ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies passkey verification for single- and double-base64-encoded
userHandle.When a passkey is created on e.g.
5.7.11(webauthn4.9.x), the credential’suserHandleis base64 encoded once.When a passkey is created on
5.9.16+ (webauthn5.2.x), the credential’suserHandleis base64 encoded twice.When logging someone in via passkeys route, it looked like we’ve always been checking
userHandleagainst base64 encoded User UID (inAuth::verifyPasskey()>$this->webauthnServer()->getAuthenticatorAssertionResponseValidator()->check()) as theAuth::passkeyUserEntity()was base64 encoding the user’s UID, but then thePublicKeyCredentialUserEntity::createFromArray()was decoding it again, so effectively the check was run on two raw UIDs and we had a match.With the update to webauthn v5 (
5.9.16+) and the removal ofPublicKeyCredentialUserEntity::createFromArray()method, the user entity is now this object, and there’s no decoding step there, so with passkeys created in webauthn v4, we were comparing users’ UID to the base64 version of it.Related issues
#19530