Fix currency label height and border radius in Money and Number fields - #19547
Merged
Merged
Conversation
Member
|
Thank you! |
Member
|
Craft 5.11.2 is out with that fix. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a minor height discrepancy between the currency labels of Money and Number (with currency preview format) fields and their adjoining inputs, as well as a left border radius being applied to the Number input when it has a label in front:
Using
min-height: var(--input-height), like.textdoes, instead ofheight:100%, makes both the same height. Adding the& + .textrule that the Money label already has to the Number label fixes the border radius.