Bugfix/19657 passkeys and algorithms - #19660
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
webauthn-lib: 5.3.9updatedcbor-phpandcose-libdependencies to^3.4and^4.8respectively.cose-lib: 4.8.0started emitting warnings when non-standardED256andED512algorithms are used.To minimise the impact of this change, I’ve:
ED256ED256from the list of algorithms that are used during creation of passkeys, so that no new passkeys are created using itSince removing
ED256from the list of verification algorithms would render any passkeys created with that algorithm invalid, we should only drop that option in either5.12or6.0. Hopefully, since that option was always last on the list, there shouldn’t be many of those.Related issues
#19657