Uh oh!
There was an error while loading. Please reload this page.
Fix more automated issues from site scan - #780
Conversation
✅ Deploy Preview for craft-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Improves theme accessibility by moving “red” to a CSS variable and refactoring overflow-focus logic into a reusable helper used by both global utilities and the BrowserShot component.
Changes:
- Replace Tailwind’s
redcolor withvar(--color-red)and define--color-redin theme CSS variables. - Refactor “make overflowing containers focusable” logic into
applyTabindexIfOverflowing()and reuse it inBrowserShot. - Adjust link/term styling and a few UI color variables for improved contrast/affordance.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tailwind.config.js | Switch red to a CSS variable for theme-aware coloring. |
| docs/.vuepress/theme/util/index.js | Reuse new overflow tabindex helper in makeOverflowingContainersFocusable(). |
| docs/.vuepress/theme/util/apply-tabindex-if-overflowing.js | New helper to apply/remove tabindex based on overflow state. |
| docs/.vuepress/theme/styles/color-mode.pcss | Define --color-red for dark-mode contexts. |
| docs/.vuepress/theme/styles/base.pcss | Update UI/link variables and define default --color-red. |
| docs/.vuepress/theme/global-components/Term.vue | Make glossary term links more visually discoverable. |
| docs/.vuepress/theme/global-components/InfoHud.vue | Adjust SVG icon fill behavior. |
| docs/.vuepress/theme/global-components/BrowserShot.vue | Add viewport ref and apply overflow tabindex logic after mount/image load. |
| docs/.vuepress/components/Generator.vue | Remove hover-based opacity transitions from generator sub-elements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Description
See issues below. In addition, fixes code from the previous attempted fix of overflowing containers not getting
tabindex="0"by checking component overflow and image load on mountRelated issues
ACC-198, ACC-207