Skip to content

Fix more automated issues from site scan - #780

Merged
gcamacho079 merged 6 commits into
mainfrom
a11y/august2026
Aug 12, 2026
Merged

Fix more automated issues from site scan#780
gcamacho079 merged 6 commits into
mainfrom
a11y/august2026

Conversation

@gcamacho079

@gcamacho079gcamacho079 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

See issues below. In addition, fixes code from the previous attempted fix of overflowing containers not getting tabindex="0" by checking component overflow and image load on mount

Related issues

ACC-198, ACC-207

@gcamacho079
gcamacho079 requested a lite review from CopilotAugust 11, 2026 14:56
@netlify

netlifyBot commented Aug 11, 2026

Copy link
Copy Markdown

Deploy Preview for craft-docs ready!

NameLink
🔨 Latest commitb19c196
🔍 Latest deploy loghttps://app.netlify.com/projects/craft-docs/deploys/6a7b5dd51435a30008480ef7
😎 Deploy Previewhttps://deploy-preview-780--craft-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves theme accessibility by moving “red” to a CSS variable and refactoring overflow-focus logic into a reusable helper used by both global utilities and the BrowserShot component.

Changes:

  • Replace Tailwind’s red color with var(--color-red) and define --color-red in theme CSS variables.
  • Refactor “make overflowing containers focusable” logic into applyTabindexIfOverflowing() and reuse it in BrowserShot.
  • Adjust link/term styling and a few UI color variables for improved contrast/affordance.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
tailwind.config.jsSwitch red to a CSS variable for theme-aware coloring.
docs/.vuepress/theme/util/index.jsReuse new overflow tabindex helper in makeOverflowingContainersFocusable().
docs/.vuepress/theme/util/apply-tabindex-if-overflowing.jsNew helper to apply/remove tabindex based on overflow state.
docs/.vuepress/theme/styles/color-mode.pcssDefine --color-red for dark-mode contexts.
docs/.vuepress/theme/styles/base.pcssUpdate UI/link variables and define default --color-red.
docs/.vuepress/theme/global-components/Term.vueMake glossary term links more visually discoverable.
docs/.vuepress/theme/global-components/InfoHud.vueAdjust SVG icon fill behavior.
docs/.vuepress/theme/global-components/BrowserShot.vueAdd viewport ref and apply overflow tabindex logic after mount/image load.
docs/.vuepress/components/Generator.vueRemove hover-based opacity transitions from generator sub-elements.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment threaddocs/.vuepress/theme/util/index.js Outdated
Comment threaddocs/.vuepress/theme/global-components/InfoHud.vue
Comment threaddocs/.vuepress/theme/util/apply-tabindex-if-overflowing.js
@gcamacho079gcamacho079 added the Accessibility WCAG violations and usability issues. label Aug 11, 2026
@gcamacho079gcamacho079 changed the title A11y/august2026Fix more automated issues from site scanAug 11, 2026
@gcamacho079
gcamacho079 marked this pull request as ready for review August 11, 2026 17:42
@gcamacho079
gcamacho079 requested a review from a team as a code ownerAugust 11, 2026 17:42
@gcamacho079
gcamacho079 merged commit 501bcab into mainAug 12, 2026
9 checks passed
@gcamacho079
gcamacho079 deleted the a11y/august2026 branch August 12, 2026 16:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AccessibilityWCAG violations and usability issues.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@gcamacho079