Allow custom functions to return nonzero BLOB - #121
Open
jyopp wants to merge 1 commit into
Open
Conversation
BrannonKing
commented
Jun 10, 2021
Fixes #124 |
AdamSLevy
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. minor nit in the tests.
| if stmt.ColumnBytes(0, got) != len(want) || !bytes.Equal(got, want) { | ||
| t.Errorf("blobcat(x'ff00',x'00ba')='%x', want '%x'", got, want) | ||
| } | ||
| stmt.Finalize() |
Collaborator
There was a problem hiding this comment.
defer this after line 155 please
| if got, want := stmt.ColumnText(0), "strcat"; got != want { | ||
| t.Errorf("strcat('str','','cat')='%s', want '%s'", got, want) | ||
| } | ||
| stmt.Finalize() |
| t.Fatal("Error does not match expected description") | ||
| } | ||
| stmt.Finalize() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contextlacks the expected methodResultBlobfor nonzero blobs, even though it implementsResultZeroBlobfor zeroed blobs of arbitrary size. As a result, custom functions cannot currently return[]byteresults, such as cryptographic hashes.