Uh oh!
There was an error while loading. Please reload this page.
OSX build fix - #32
Conversation
WolfgangFellger
commented
Jan 12, 2016
Thank you. What exactly does "(tests fail)" mean? There's not much point in having the build "fixed" when it doesn't actually work... |
diegoperini
commented
Jan 12, 2016
Test results: |
atdrago
commented
Mar 7, 2016
Please consider merging this PR and republishing to NPM. Your package cannot be built on Mac OS X as is. |
@WolfgangFellger@rashfael Please consider merging this PR |
rashfael
commented
Dec 27, 2016
Neither @WolfgangFellger nor I are with creatale anymore, sorry. |
thlorenz
commented
Jan 20, 2017
@krithixy I merged @diegoperini's fixes (this PR) into my fork: https://github.com/thlorenz/ndv and published as I hope we can get the other PRs that are pending here merged there as well and thus keep it working on all platforms. |
diegoperini
commented
Jan 20, 2017
@thlorenz You should consider editting the README as well as the repo description to indicate your fork has a purpose other than assuming ownership. You may add something like "A fork of node-dv with OS X build fix". 👍 |
thlorenz
commented
Jun 2, 2017
@diegoperini it already provides that info as a github feature, i.e. look at the top of the repo it'll say where it was forked from. |
Edit: Fixed minimum OSX