Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 74
Consolidate checks for completion file exists #271
Copy link
Copy link
Labels
✨ goal: improvementImprovement to an existing featureImprovement to an existing feature🏁 status: ready for workReady for workReady for work💻 aspect: codeConcerns the software code in the repositoryConcerns the software code in the repository🟨 priority: mediumNot blocking but should be fixed soonNot blocking but should be fixed soon
Description
Metadata
Metadata
Assignees
Labels
✨ goal: improvementImprovement to an existing featureImprovement to an existing feature🏁 status: ready for workReady for workReady for work💻 aspect: codeConcerns the software code in the repositoryConcerns the software code in the repository🟨 priority: mediumNot blocking but should be fixed soonNot blocking but should be fixed soon
Type
Projects
StatusShow more project fields
Done
Description
The existing shared function used by process scripts:
quantifying/scripts/shared.py
Lines 39 to 46 in dae9e83
and the report functions, for example:
quantifying/scripts/3-report/gcs_report.py
Lines 78 to 92 in dae9e83
can be combined into a single shared function that serves both needs.
check_completion_file_existsinstead ofcheck_for_data_filesargs.quarterinstead of a dedicatedQUARTERargumentfile_pathslist can contain a single pathImplementation