Uh oh!
There was an error while loading. Please reload this page.
Add Museums Victoria fetch - #223
Conversation
sbarhin
commented
Oct 30, 2025
@oree-xx I have opened a new pull request. I guess that is much better |
oree-xx
commented
Oct 30, 2025
@sbarhin ohh okay great. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
sbarhin
commented
Oct 31, 2025
@TimidRobot There are several file changes in my PR, this is due to pulling from the main branch where I believe you merged a certain PR. These changes have taken effect in my branch hence those file changes in my PR. |
TimidRobot
commented
Oct 31, 2025
Please revisit the documentation on keeping a branch/fork synchronized with upstream and on resolving merge conflicts. This PR won't be reviewed or merged while these issue are present. |
sbarhin
commented
Oct 31, 2025
I will do that please. Thank you |
sbarhin
commented
Oct 31, 2025
@TimidRobot I believe we are good now |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TimidRobot
commented
Nov 5, 2025
@sbarhin Which implementation will satisfies the stated goal? |
TimidRobot
commented
Nov 5, 2025
@sbarhin force pushes are generally a worst practice and should be avoided when unnecessary. |
sbarhin
commented
Nov 5, 2025
I think per individual record type will do |
sbarhin
commented
Nov 6, 2025
@TimidRobot Please what are the next steps? Seems everything is resolved now |
Uh oh!
There was an error while loading. Please reload this page.
| licence_data = media_item.get("licence") | ||
| # COUNTING THE UNIQUE LICENCE TYPES | ||
| license_short_name = licence_data.get("shortName") |
There was a problem hiding this comment.
Unfortunately, the license short name is not reliable (does not include version number).
There was a problem hiding this comment.
The new PR includes the version name to the license name.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TimidRobot
left a comment
There was a problem hiding this comment.
Good work, thank you!
(I am merging this to a feature branch as I want legal tool identification to be based on data that is not yet readily available.)
Fixes
Description
This PR implements automation for Museum Victoria data fetching as discussed in issue #215. The implementation follows the established patterns from existing fetch scripts.
This purpose of this file is to fetch all the records from the Museum Victoria API, then saving the necessary response fields needed for the next phase (processing phase).
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin