Skip to content

Move data_to_csv function to shared.py - #267

Merged
TimidRobot merged 4 commits into
creativecommons:mainfrom
oree-xx:data
Jan 21, 2026
Merged

Move data_to_csv function to shared.py#267
TimidRobot merged 4 commits into
creativecommons:mainfrom
oree-xx:data

Conversation

@oree-xx

@oree-xxoree-xx commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

Fixes

Description

I moved the function data_to_csv to shared.py to make the code neat and consistent.

Checklist

  • I have read and understood the Developer Certificate of Origin (DCO), below, which covers the contents of this pull request (PR).
  • My pull request doesn't include code or content generated with AI (also see Avoiding generative AI development tools — Creative Commons Open Source).
  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated unit tests and/or test scripts for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@oree-xx
oree-xx requested review from a team as code ownersJanuary 16, 2026 11:15
@oree-xx
oree-xx requested review from TimidRobot and possumbilities and removed request for a teamJanuary 16, 2026 11:15
@cc-open-source-botcc-open-source-bot moved this to In review in TimidRobotJan 16, 2026
@TimidRobotTimidRobot self-assigned this Jan 20, 2026

@TimidRobotTimidRobot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the conflicts

(don't forget to fetch/merge changes before you begin new work!)

Comment threadscripts/2-process/gcs_process.py Outdated
Comment threadscripts/2-process/github_process.py Outdated
Comment threadscripts/2-process/github_process.py Outdated
Comment threadscripts/2-process/wikipedia_process.py Outdated
Comment threadscripts/2-process/wikipedia_process.py Outdated
Comment threadscripts/2-process/wikipedia_process.py Outdated
Comment threadscripts/shared.py Outdated
Comment threadscripts/shared.py Outdated

@TimidRobotTimidRobot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully args.paths is consistent across the process scripts (not so with other phases). Using it will simplify your improvements just a bit.

@TimidRobotTimidRobot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work, thank you!

@TimidRobot
TimidRobot merged commit d2a80ee into creativecommons:mainJan 21, 2026
@github-project-automationgithub-project-automationBot moved this from In review to Done in TimidRobotJan 21, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants

@oree-xx@TimidRobot@cc-open-source-bot