Uh oh!
There was an error while loading. Please reload this page.
chore: bump the self-referential apis/v2 requirement at release time - #99
Open
phisco wants to merge 1 commit into
Open
chore: bump the self-referential apis/v2 requirement at release time#99phisco wants to merge 1 commit into
phisco wants to merge 1 commit into
Conversation
The root go.mod requires github.com/crossplane/crossplane/apis/v2 and replaces it with ./apis. The replace only applies in the main module, so for anything importing github.com/crossplane/crossplane/v2 that requirement is the minimum apis version resolved from the proxy — and a stale value publishes a module that does not compile. crossplane/v2@v2.4.0 recorded apis v2.3.4, which lacks v1.RuntimeActive and friends. Renovate only bumps this on main; release branches have non-security Go updates disabled, so it has to be part of the release checklist. Folded into the runtime-bump PRs already there, so it costs no extra steps. The Tag workflow creates apis/vX.Y.Z at the same commit as vX.Y.Z, so the PR can name a tag that does not exist yet. Signed-off-by: Philippe Scorsolini <5697904+phisco@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
go.modrequiresgithub.com/crossplane/crossplane/apis/v2and replaces it with./apis. The replace only applies in the main module, so for anything importinggithub.com/crossplane/crossplane/v2that requirement is the minimum apis version resolved from the proxy — and a stale value publishes a module that does not compile.crossplane/v2@v2.4.0recorded apisv2.3.4, which lacksv1.RuntimeActiveand friends.Renovate only bumps this on
main; release branches have non-security Go updates disabled, so it has to be part of the release checklist. Folded into the runtime-bump PRs already there, so it costs no extra steps. The Tag workflow createsapis/vX.Y.Zat the same commit asvX.Y.Z, so the PR can name a tag that does not exist yet.