Uh oh!
There was an error while loading. Please reload this page.
v3.2.2 - #405
Open
rongxin-liu wants to merge 14 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Vietnamese language support and introduces new authentication options (--https and --ssh) for submit50 version 3.2.2.
Changes:
- Added Vietnamese translation files (.po and .mo) with translations for existing user-facing messages
- Added --https and --ssh command-line arguments to allow users to force specific authentication methods
- Updated version from 3.2.1 to 3.2.2
- Modernized GitHub Actions workflow syntax
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| submit50/locale/vi/LC_MESSAGES/submit50.po | Vietnamese translation file with translations for user-facing messages; contains some incomplete translations |
| submit50/locale/vi/LC_MESSAGES/submit50.mo | Compiled Vietnamese translation file (binary format) |
| submit50/main.py | Added LOGGER constant, --https/--ssh arguments, and authentication method selection logic |
| setup.py | Version bump from 3.2.1 to 3.2.2 |
| .github/workflows/main.yml | Updated deprecated GitHub Actions syntax for setting output variables |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…tup-python, and github-script
lib50.push() only accepts auth_method from 3.1.2 onward, but the pin admitted 3.0.x-3.1.1, which made every submission fail with a TypeError for users whose lib50 pip had no reason to upgrade. Also: raise an actionable error when a forced --ssh login fails (lib50 raises a bare ConnectionError there), skip the localized yes-regex under RSTUDIO instead of matching a hard-coded "yes" against it, surface the both-flags warning via cprint like other warnings, and fix the missing space in the submit.cs50.io error text.
Translate the --https/--ssh help, --log-level help, slug help, the combined-flag warning and the new SSH failure message; restore the missing spaces where multi-line msgstr fragments were joined; accept ASCII "co" as an affirmative; distinguish "User aborted submission." from "Submission cancelled."; recompile the committed .mo.
CI previously only ran `submit50 --help`, so a lib50 API mismatch could ship to PyPI unnoticed. The new tests wire each --https/--ssh flag combination through main() to lib50.push, check the forced-SSH error path, and verify every _() string is translated and the committed .mo matches its .po. The workflow runs them against both the newest lib50 and the floor declared in setup.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.