Uh oh!
There was an error while loading. Please reload this page.
Let define syntax for extensions; Fix #6 - #7
Merged
Conversation
tonyganch
commented
Sep 27, 2015
Member
Here: https://github.com/csscomb/core/blob/dev/src/core.js#L135 |
tonyganch
commented
Sep 27, 2015
Member
It is. Thank you 🐘 |
isqua
commented
Sep 27, 2015
ContributorAuthor
🆙 |
Member
There was a problem hiding this comment.
You can't be sure that map was copied because {} is the default value it gets even if configuration fails.
I'd offer replacing on line 27 syntax: {} with syntax: {'.css': 'scss'}, for example.
ContributorAuthor
There was a problem hiding this comment.
assert.equal check pointers, not values:
assert.equal({},{});// => falseleta={};letb=a;assert.equal(a,b);// true...
isqua
commented
Sep 27, 2015
ContributorAuthor
Is Map usage ok? If so, I’ll squash commits. |
tonyganch
commented
Sep 27, 2015
Member
Map is ok. Let me know when to merge. |
isqua
commented
Sep 27, 2015
ContributorAuthor
It’s ready to merge now 🔥 |
tonyganch
commented
Sep 27, 2015
Member
Thank you very much 👯 |
isqua
commented
Sep 28, 2015
ContributorAuthor
When csscomb.js will support this feature? |
rodfersou
commented
Oct 23, 2015
I'm interested in this feature too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion: #6
In
.csscomb.json:{ "syntax": { ".css": "scss", ".lss": "less" } }If the implementation is ok, I’ll write tests.