Uh oh!
There was an error while loading. Please reload this page.
Yh cyber windowed blending sampler - #53
Conversation
Coverage Report for CI Build 32797978609Coverage increased (+1.0%) to 97.822%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
KurbyDoo
left a comment
There was a problem hiding this comment.
overall the structure looks good, just some things to clean up function boundaries and make testing easier
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
KurbyDoo
commented
Aug 22, 2026
I have a fix for the script error? Could you take a look #54 |
…d pytest-mocker to project dependencies
… yh-cyber-windowed-blending-sampler
I've implemented all changes! |
KurbyDoo
left a comment
There was a problem hiding this comment.
Right now the windows are dependent on the region which is fine for now, later we will work to make them independent of the requested region and instead based on a global coordinate space. I'll make tickets for that later
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
KurbyDoo
left a comment
There was a problem hiding this comment.
thanks for addressing my comments, looks good to merge after this
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
yh-cyber
commented
Aug 25, 2026
np, thnx. once you take a look and resolve the conversations, ill squash and merge. |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Validation
scripts/quality-check.shpasses locally/testcommands were run and are passing (e.g./test gpu)Checklist
Additional Comments
I think there might be something wrong with scripts/quality-check.sh for me.
This is what I got when I ran scripts/quality-check.sh