Uh oh!
There was an error while loading. Please reload this page.
json-writer: print level key in SARIF output - #81
Conversation
kdudka
left a comment
There was a problem hiding this comment.
Thank you for working on it! Some minor issues inline...
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
... so that users can easily filter results according to their severity. Fixes: csutils#80 Co-authored-by: Kamil Dudka <kdudka@redhat.com> Co-authored-by: Lukáš Zaoral <lzaoral@redhat.com>
| pDst->put_child("message", msg); | ||
| } | ||
| static void sarifEncodeLevel(PTree *result, const std::string &event) { |
There was a problem hiding this comment.
Note to self: fix bracket formatting inconsistency in some future commit
There was a problem hiding this comment.
We might consider using this one-liner in CI to catch this:
grep '^static .*) *{$' src/*
There is one more inconsistency in abstarct-parser.cc:
src/abstract-parser.cc:static inline std::unique_ptr<T> make_unique(InStream &input) {
src/json-writer.cc:static void sarifEncodeLevel(PTree *result, const std::string &event) {
There was a problem hiding this comment.
Using a custom .clang-format config to enforce code style is would be a better solution. Tracked in #86.
There was a problem hiding this comment.
That would mean more work than the proposed one-liner. But if we have a volunteer to work on this, why not :-)
There was a problem hiding this comment.
It's not that hard, I've already done it few times. Additionally, such config file can be then used in all of our projects.
... so that users can easily filter results according to their severity.
Fixes: #80