Skip to content

json-parser: basic support for ShellCheck's JSON output - #83

Merged
kdudka merged 1 commit into
csutils:mainfrom
kdudka:shellcheck-json
Oct 3, 2022
Merged

json-parser: basic support for ShellCheck's JSON output#83
kdudka merged 1 commit into
csutils:mainfrom
kdudka:shellcheck-json

Conversation

@kdudka

@kdudkakdudka commented Sep 8, 2022•
edited by jamacku
Loading

Copy link
Copy Markdown
Member

... which is produced by shellcheck --format=json1 ...

@kdudkakdudka mentioned this pull request Sep 8, 2022
Open
@jamackujamacku mentioned this pull request Sep 8, 2022
Closed
1 task
@jamackujamacku linked an issue Sep 8, 2022 that may be closed by this pull request
Please add support for ShellCheck JSON format #75
Open
@kdudka

kdudka commented Sep 30, 2022

Copy link
Copy Markdown
MemberAuthor

I think this is safe to be merged. We can extend the support for ShellCheck's JSON output in subsequent merge requests.

@kdudka
kdudka marked this pull request as ready for review September 30, 2022 08:31
@kdudka
kdudka requested a review from lzaoralSeptember 30, 2022 08:31
jamacku
jamacku requested changes Sep 30, 2022
View reviewed changes

@jamackujamacku left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdudka Thank you. Only one small thing. I think the commit message should say --format=json1 instead of only json as mentioned in:

kdudka added a commit to kdudka/csdiff that referenced this pull request Sep 30, 2022
@kdudka
json-parser: basic support for ShellCheck's JSON output
5b7b712
... which is produced by `shellcheck --format=json1 ...`
Fixes: csutils#75Closes: csutils#83
@kdudka

kdudka commented Sep 30, 2022

Copy link
Copy Markdown
MemberAuthor

@jamacku Good catch! Fixed.

lzaoral
lzaoral requested changes Sep 30, 2022
View reviewed changes

@lzaorallzaoral left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great but I'd drop the Fixes: from the commit message. The issue was specifically asking about handling of ShellCheck's suggestions which are still marked as a TODO.

Edit: Maybe Related: is more appropriate.

@kdudka
json-parser: basic support for ShellCheck's JSON output
3ab6fbf
... which is produced by `shellcheck --format=json1 ...`
Related: csutils#75Closes: csutils#83
@kdudka

kdudka commented Sep 30, 2022

Copy link
Copy Markdown
MemberAuthor

@lzaoral You are right. Fixed.

lzaoral
lzaoral approved these changes Sep 30, 2022
View reviewed changes

@lzaorallzaoral left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kdudka!

@kdudkakdudka closed this in 3ab6fbfOct 3, 2022
@kdudka
kdudka merged commit 3ab6fbf into csutils:mainOct 3, 2022
@kdudka

kdudka commented Oct 3, 2022

Copy link
Copy Markdown
MemberAuthor

@lzaoral Note that using Related: in the commit message does not prevent GitHub from closing the issue.

@lzaoral

lzaoral commented Oct 3, 2022

Copy link
Copy Markdown
Member

Sorry, @kdudka. I did not know that and it is a rather stupid behaviour.

@kdudka

kdudka commented Oct 5, 2022•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

My bad. The issue was explicitly linked with the pull request on GitHub. The use of Related: in the commit message was in fact unrelated to my observation. @lzaoral Thank you for pointing it out!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jamackujamackujamacku approved these changes
@lzaorallzaorallzaoral approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Please add support for ShellCheck JSON format

3 participants

@kdudka@lzaoral@jamacku