Skip to content

Implement new configurbles in TableReader + rename some process funct… - #16

Merged
ctolon merged 1 commit into
ctolon:mainfrom
feisenhu:main
Nov 24, 2022
Merged

Implement new configurbles in TableReader + rename some process funct…#16
ctolon merged 1 commit into
ctolon:mainfrom
feisenhu:main

Conversation

@feisenhu

Copy link
Copy Markdown
Contributor

…ions

In my latest pull request in O2Physics I have introduced some new configurables now used in the TableReader and also applied some renaming of some processFunctions.

In case the PR is merged, this PR would help to keep consistency of the interface.

@ctolonctolon assigned ctolon and feisenhu and unassigned ctolonNov 24, 2022
@ctolonctolon added enhancement New feature or request maintaince Maintaince PRs regarding to O2-DQ Workflows labels Nov 24, 2022
@ctolon

Copy link
Copy Markdown
Owner

@feisenhu thanks for your reminder and update, I will also integrate the arguments and configurations for the CLI immediately

@ctolon
ctolon merged commit c9bc65f into ctolon:mainNov 24, 2022
@feisenhu

feisenhu commented Nov 24, 2022

Copy link
Copy Markdown
ContributorAuthor

@ctolon I'm sorry that I didn't mentioned it but the above pull request is not merged yet.
So please make sure that it will not come to major conflicts.

This PR was meant to be merged after the other PR is merged so everything goes hand in hand.

In case Ionut will approve the other PR soon we might be able to keep it like that.

@ctolon

Copy link
Copy Markdown
Owner

@feisenhu I see, then I'm reverting these changes for now, when these changes are merged in O2Physics, we can merge them here again. Thanks again

ctolon added a commit that referenced this pull request Nov 24, 2022
@feisenhu

Copy link
Copy Markdown
ContributorAuthor

@ctolon The pull request in O2Physics is now merged.
So we can apply these changes again. Thank you very much.

@ctolon

Copy link
Copy Markdown
Owner

@feisenhu Thanks for letting me know, I'm re-applying the changes right away

ctolon added a commit that referenced this pull request Nov 25, 2022
ctolon added a commit that referenced this pull request Nov 25, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancementNew feature or requestmaintainceMaintaince PRs regarding to O2-DQ Workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@feisenhu@ctolon