Fix error: can't modify frozen String: "decimal" by n-rodriguez · Pull Request #895 · ctran/annotate_models

n-rodriguez · 2021-09-11T13:17:09Z

This PR fixes these errors due to the presence of # frozen_string_literal: true in files :

Unable to annotate app/models/camping.rb: can't modify frozen String: "decimal" /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:875:in `get_attributes'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:151:in `block in get_schema_info' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:149:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:149:in `get_schema_info' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:481:in `annotate'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `annotate_model_file' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:658:in `block in do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `do_annotations'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/tasks/annotate_models.rake:56:in `block in<main>'Unable to annotate app/models/camping.rb: no implicit conversion of nil into Array /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `concat' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `annotate_model_file' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:658:in `block in do_annotations'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/tasks/annotate_models.rake:56:in `block in<main>'Unable to annotate app/models/camping_raw.rb: can't modify frozen String: "decimal"
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:875:in `get_attributes' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:151:in `block in get_schema_info' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:149:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:149:in `get_schema_info'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:481:in `annotate' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `annotate_model_file' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:658:in `block in do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `each'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/tasks/annotate_models.rake:56:in `block in <main>'Unable to annotate app/models/camping_raw.rb: no implicit conversion of nil into Array /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `concat' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `annotate_model_file'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:658:in `block in do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/tasks/annotate_models.rake:56:in `block in <main>'
Unable to annotate app/models/user_profile.rb: can't modify frozen String: "decimal" /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:875:in `get_attributes'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:151:in `block in get_schema_info' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:149:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:149:in `get_schema_info' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:481:in `annotate'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `annotate_model_file' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:658:in `block in do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `do_annotations'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/tasks/annotate_models.rake:56:in `block in<main>'Unable to annotate app/models/user_profile.rb: no implicit conversion of nil into Array /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `concat' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:682:in `annotate_model_file' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:658:in `block in do_annotations'
/home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `each' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/annotate/annotate_models.rb:657:in `do_annotations' /home/nicolas/.asdf/installs/ruby/3.0.2/lib/ruby/gems/3.0.0/bundler/gems/annotate_models-786394947c04/lib/tasks/annotate_models.rake:56:in `block in<main>'

n-rodriguez · 2021-09-11T13:17:57Z

See #834

n-rodriguez · 2022-03-25T22:30:26Z

hi there! any news?

n-rodriguez · 2022-06-10T03:21:49Z

Hi there! Any change to get this merged?

n-rodriguez · 2022-09-16T10:00:17Z

ping @ctran

n-rodriguez · 2022-09-20T22:31:24Z

ping @ctran

About the failing specs : there must be some leaking states somewhere. Errors now appear because of #787.

n-rodriguez · 2022-10-23T22:52:52Z

ping @ctran

ctran · 2022-10-24T20:58:49Z

I think there's something else causing the CI failures, not your changes. I've been trying to figure out where the problem lies but it's taking me some time since I've been away from this for some time.

n-rodriguez · 2023-04-22T21:35:55Z

ping @ctran

ctran · 2023-04-23T04:50:14Z

Hi, the CI issue is now fixed on the develop branch. Did you rebase with the recent changes?

n-rodriguez · 2023-04-23T05:04:05Z

Thank you!

Resolves: ctran#834

Fix error: can't modify frozen String: "decimal"
6866586

ctran self-assigned this Oct 24, 2022

ctran added this to the v3.2.1 milestone Oct 24, 2022

ctran added 2 commits April 22, 2023 21:52

Update annotate_models.rb
43fe2ba

Update annotate_models.rb
40735b3

ctran approved these changes Apr 23, 2023
View reviewed changes

ctran merged commit 3a78787 into ctran:developApr 23, 2023

ignacio-chiazzo mentioned this pull request Sep 4, 2024
Allow running annotate for when the columns are frozen #1030
Closed

jimmynguyc pushed a commit to jimmynguyc/annotate_models that referenced this pull request Oct 29, 2025
fix: can't modify frozen String: "decimal" (ctran#895)
4cda417
Resolves: ctran#834

thatsanicehat pushed a commit to Home-Chef-Tech/annotate_models that referenced this pull request Jun 12, 2026
fix: can't modify frozen String: "decimal" (ctran#895)
b267e74
Resolves: ctran#834

Navigation Menu

Fix error: can't modify frozen String: "decimal" - #895

Fix error: can't modify frozen String: "decimal"#895
ctran merged 3 commits into
ctran:developfrom
n-rodriguez:wip/fix_frozen_strings

n-rodriguez commented Sep 11, 2021

Uh oh!

n-rodriguez commented Sep 11, 2021

Uh oh!

n-rodriguez commented Mar 25, 2022

Uh oh!

n-rodriguez commented Jun 10, 2022

Uh oh!

n-rodriguez commented Sep 16, 2022

Uh oh!

n-rodriguez commented Sep 20, 2022

Uh oh!

n-rodriguez commented Oct 23, 2022

Uh oh!

ctran commented Oct 24, 2022

Uh oh!

n-rodriguez commented Apr 22, 2023

Uh oh!

ctran commented Apr 23, 2023

Uh oh!

n-rodriguez commented Apr 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

n-rodriguez commented Sep 11, 2021

Uh oh!

n-rodriguez commented Sep 11, 2021

Uh oh!

n-rodriguez commented Mar 25, 2022

Uh oh!

n-rodriguez commented Jun 10, 2022

Uh oh!

n-rodriguez commented Sep 16, 2022

Uh oh!

n-rodriguez commented Sep 20, 2022

Uh oh!

n-rodriguez commented Oct 23, 2022

Uh oh!

ctran commented Oct 24, 2022

Uh oh!

n-rodriguez commented Apr 22, 2023

Uh oh!

ctran commented Apr 23, 2023

Uh oh!

n-rodriguez commented Apr 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants