Skip to content

Support --frozen option for routing annotations - #979

Merged
ctran merged 7 commits into
ctran:developfrom
kg8m:support-routing-frozen
Mar 30, 2023
Merged

Support --frozen option for routing annotations#979
ctran merged 7 commits into
ctran:developfrom
kg8m:support-routing-frozen

Conversation

@kg8m

@kg8mkg8m commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

Hi. Thanks for this great gem! The --frozen option is very useful.

I noticed that the --frozen option doesn't work for routing annotations (rake annotate_routes and annotate --routes). This pull request adds the support for that.

Best regards.

@kg8m
kg8mforce-pushed the support-routing-frozen branch 2 times, most recently from 1205cb8 to 66ce208CompareFebruary 12, 2023 09:37
@ctran

ctran commented Mar 29, 2023

Copy link
Copy Markdown
Owner

@kg8m Would you mind rebase against the latest develop (which has fixed the CI issues)?

Thanks.

@ctranctran self-assigned this Mar 29, 2023
@ctranctran added this to the v3.2.1 milestone Mar 29, 2023
ctran
ctran reviewed Mar 29, 2023
View reviewed changes
Comment threadlib/annotate/annotate_routes.rb Outdated
@kg8m
Support --frozen option for routing annotations
039e04c
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
@kg8m
kg8mforce-pushed the support-routing-frozen branch from 5c7c90a to 039e04cCompareMarch 29, 2023 08:40
@ctran

ctran commented Mar 29, 2023

Copy link
Copy Markdown
Owner

Could I convince you to add an unit test/spec for this new option?

@kg8m
Prefer elsif to nested ifs
a76da82
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
@kg8m
kg8m requested a review from ctranMarch 30, 2023 16:39
@kg8m
Add tests for frozen option of routing annotations
86dc2c5
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
@kg8m
kg8mforce-pushed the support-routing-frozen branch from 5d18b3c to 86dc2c5CompareMarch 30, 2023 16:43
@kg8m

kg8m commented Mar 30, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@ctran
I fixed the RuboCop error and added tests for the --frozen option of routing annotations. Could you please review the changes?

Best regards.

ctran
ctran requested changes Mar 30, 2023
View reviewed changes
Comment threadlib/annotate/annotate_routes.rb
Comment threadspec/lib/annotate/annotate_routes_spec.rb
ctran
ctran reviewed Mar 30, 2023
View reviewed changes
Comment threadlib/annotate/annotate_routes.rb
ctran
ctran approved these changes Mar 30, 2023
View reviewed changes

@ctranctran left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the suggestions directly on your fork, hope you don't mind.

@ctran
ctran merged commit 10a7a76 into ctran:developMar 30, 2023
@kg8m

kg8m commented Mar 31, 2023

Copy link
Copy Markdown
ContributorAuthor

@ctran
Thank you so much!

jimmynguyc pushed a commit to jimmynguyc/annotate_models that referenced this pull request Oct 29, 2025
@kg8m@ctran@jimmynguyc
Support--frozenoption for routing annotations (ctran#979)
1da0fec
The `--frozen` option previously deal only model annotations. This change will support route annotations as well.
---------
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
Co-authored-by: Cuong Tran <ctran@users.noreply.github.com>
thatsanicehat pushed a commit to Home-Chef-Tech/annotate_models that referenced this pull request Jun 12, 2026
@kg8m@ctran@thatsanicehat
Support--frozenoption for routing annotations (ctran#979)
69b5bc1
The `--frozen` option previously deal only model annotations. This change will support route annotations as well.
---------
Signed-off-by: kg8m <takumi.kagiyama@gmail.com>
Co-authored-by: Cuong Tran <ctran@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctranctranctran approved these changes

Assignees

@ctranctran

Labels

bugfeature

Projects

None yet

Milestone

v3.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@kg8m@ctran