Skip to content

Fix flaky specs - #980

Merged
ctran merged 1 commit into
ctran:developfrom
lovro-bikic:fix_flaky_specs
Mar 29, 2023
Merged

Fix flaky specs#980
ctran merged 1 commit into
ctran:developfrom
lovro-bikic:fix_flaky_specs

Conversation

@lovro-bikic

@lovro-bikiclovro-bikic commented Mar 28, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes flaky specs which fail the CI.

I ran the test suite a couple of hundred of times locally with different seeds to make sure nothing else fails. I couldn't find any other issues.

@lovro-bikic
lovro-bikicforce-pushed the fix_flaky_specs branch 2 times, most recently from abbfc88 to 62e25edCompareMarch 28, 2023 22:43
@lovro-bikic
Fix flaky specs
e99466a
Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr>
lovro-bikic
lovro-bikic commented Mar 28, 2023
View reviewed changes
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
Comment threadspec/lib/annotate/annotate_models_spec.rb
@lovro-bikiclovro-bikic mentioned this pull request Mar 28, 2023
Merged
@ctran

ctran commented Mar 29, 2023

Copy link
Copy Markdown
Owner

Thanks!!!

ctran
ctran approved these changes Mar 29, 2023
View reviewed changes

@ctranctran left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much appreciated!

@ctran
ctran merged commit 76a1804 into ctran:developMar 29, 2023
@ctranctran self-assigned this Mar 29, 2023
@ctranctran added this to the v3.2.1 milestone Mar 29, 2023
@lovro-bikic
lovro-bikic deleted the fix_flaky_specs branch March 29, 2023 08:19
jimmynguyc pushed a commit to jimmynguyc/annotate_models that referenced this pull request Oct 29, 2025
@lovro-bikic@jimmynguyc
Fix flaky specs (ctran#980)
3c38b66
Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr>
thatsanicehat pushed a commit to Home-Chef-Tech/annotate_models that referenced this pull request Jun 12, 2026
@lovro-bikic@thatsanicehat
Fix flaky specs (ctran#980)
0ec5c8b
Signed-off-by: Lovro Bikic <lovro.bikic@infinum.hr>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctranctranctran approved these changes

Assignees

@ctranctran

Labels

None yet

Projects

None yet

Milestone

v3.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@lovro-bikic@ctran