Skip to content

Make with_comment_column work with Annotate.set_defaults - #999

Merged
ctran merged 10 commits into
ctran:developfrom
Adeynack:feature/make_with_comment_column_work_with_annotate_set_defaults
Nov 30, 2023
Merged

Make with_comment_column work with Annotate.set_defaults#999
ctran merged 10 commits into
ctran:developfrom
Adeynack:feature/make_with_comment_column_work_with_annotate_set_defaults

Conversation

@Adeynack

@AdeynackAdeynack commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Fixes#990

@AdeynackAdeynack mentioned this pull request Nov 15, 2023
Closed
@Adeynack
Adeynack marked this pull request as ready for review November 15, 2023 00:06
@sureshc

sureshc commented Nov 15, 2023

Copy link
Copy Markdown

Thank you! I'm not familiar with this codebase. Are there any tests that need to be updated to validate this change?

@Adeynack

Adeynack commented Nov 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@sureshc : The only test I found that seems to concern .set_defaults are strangely specific to ONE configuration key, so I decided to not touch it. @ctran can maybe point me at where it would be decent to test this thing. I am also very uncomfortable in submitting modifications without any kind of automated testing proving its worth.

@ctran

ctran commented Nov 15, 2023

Copy link
Copy Markdown
Owner

@sureshc : The only test I found that seems to concern .set_defaults are strangely specific to ONE configuration key, so I decided to not touch it. @ctran can maybe point me at where it would be decent to test this thing. I am also very uncomfortable in submitting modifications without any kind of automated testing proving its worth.

Maybe add a new test in https://github.com/ctran/annotate_models/blob/master/spec/lib/tasks/annotate_models_migrate_spec.rb?

@Adeynack

Adeynack commented Nov 15, 2023

Copy link
Copy Markdown
ContributorAuthor

@ctran : I added a brand new spec file for it, since I judged it was a separate concern than what's in annotate_models_migrate_spec. But thanks a lot for this hint, it pushed me directly in the right direction! 🤩

Adeynack
Adeynack commented Nov 15, 2023
View reviewed changes
Comment threadspec/lib/tasks/annotate_models_spec.rb
@Adeynack

Adeynack commented Nov 29, 2023

Copy link
Copy Markdown
ContributorAuthor

@sureshc@ctran : Code is complete & tests were written. Please review 😺

ctran
ctran approved these changes Nov 30, 2023
View reviewed changes

@ctranctran left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

Comment threadspec/lib/tasks/annotate_models_spec.rb
@ctranctran self-assigned this Nov 30, 2023
@ctranctran added this to the v3.2.1 milestone Nov 30, 2023
@ctran
ctran merged commit 5d01c41 into ctran:developNov 30, 2023
@Adeynack
Adeynack deleted the feature/make_with_comment_column_work_with_annotate_set_defaults branch November 30, 2023 10:34
@omkarmogheomkarmoghe mentioned this pull request Jan 6, 2024
Open
@AdeynackAdeynack mentioned this pull request Nov 14, 2024
Closed
jimmynguyc pushed a commit to jimmynguyc/annotate_models that referenced this pull request Oct 29, 2025
@Adeynack@jimmynguyc
Makewith_comment_columnwork withAnnotate.set_defaults(ctran#999)
dd19e1e
thatsanicehat pushed a commit to Home-Chef-Tech/annotate_models that referenced this pull request Jun 12, 2026
@Adeynack@thatsanicehat
Makewith_comment_columnwork withAnnotate.set_defaults(ctran#999)
bf51ba3
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctranctranctran approved these changes

Assignees

@ctranctran

@AdeynackAdeynack

Labels

None yet

Projects

None yet

Milestone

v3.2.1

Development

Successfully merging this pull request may close these issues.

Make with_comment_column work with Annotate.set_defaults

3 participants

@Adeynack@sureshc@ctran