Uh oh!
There was an error while loading. Please reload this page.
Add run_interdiff - #35
Conversation
PlaidCat
left a comment
There was a problem hiding this comment.
I have some nitpicks, but they're the same hole I fell into using Claude as well.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| print("Please install patchutils or specify path with --interdiff") | ||
| sys.exit(1) | ||
| # Validate that all required refs exist |
There was a problem hiding this comment.
This will be interesting to see if this works with remote fork PRs
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kerneltoast
commented
Oct 17, 2025
The final version of the fuzzy feature that I submitted as a PR upstream (twaugh/patchutils#147) requires passing |
e2d3547 to
9da07b2CompareThis is a wrapper for running interdiff on pr commits that are backports of upstream kernel commits. The calling convention is similar to check_kernel_commits, where you pass the kernel-src-tree repo, the pr branch, and base branch as arguments. The script then looks though each pr commit looking for backported upstream commits, and calls interdiff to check for differences between the referenced upstream commit and the pr commit itself. As with check_kernel_commits the --markdown argument adds a little flair for embedding the output in a github comment The --interdiff argument allows for passing an alternative path for which interdiff executable is used. This will likely be used by the calling github action to use a custom built interdiff until mainline interdiff can do the fuzzy matching we like.
bmastbergen
commented
Oct 22, 2025
Cool. Added --fuzzy to interdiff call |
PlaidCat
left a comment
There was a problem hiding this comment.
I'm good with this first pass and getting a 80%+ code in place
This is a wrapper for running interdiff on pr commits that are backports of upstream kernel commits. The calling convention is similar to check_kernel_commits, where you pass the kernel-src-tree repo, the pr branch, and base branch as arguments. The script then looks though each pr commit looking for backported upstream commits, and calls interdiff to check for differences between the referenced upstream commit and the pr commit itself.
As with check_kernel_commits the --markdown argument adds a little flair for embedding the output in a github comment
The --interdiff argument allows for passing an alternative path for which interdiff executable is used. This will likely be used by the calling github action to use a custom built interdiff until mainline interdiff can do the fuzzy matching we like.
An example of how this could be integrated into our existing upstream_commit_check github action workflow is available here:
ctrliq/kernel-src-tree@f8718c0
An example of its output as a github comment is available here:
ctrliq/kernel-src-tree#621 (comment)
This was written by claude BTW. Claude used check_kernel_commits as inspiration so the calling convention and code would be similar. Hopefully similar code could be pulled out into a library and shared some day.