Skip to content

kt: Introduce kt checkout/vm for rlc kernels - #78

Open
roxanan1996 wants to merge 1 commit into
mainlinefrom
{rnicolescu}_kt_add_rlc_checkout_and_vm
Open

kt: Introduce kt checkout/vm for rlc kernels#78
roxanan1996 wants to merge 1 commit into
mainlinefrom
{rnicolescu}_kt_add_rlc_checkout_and_vm

Conversation

@roxanan1996

@roxanan1996roxanan1996 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Similar to current implementation for the lts kernels, except for 2 changes:

  1. source tree branch changes for rlc when a new version is released, hence we cannot lock a specific version in kernels.yaml file. Instead a pattern is used. And when kt checkout is used, the latest branch that matches the pattern is found and used.
  2. if a new minor rocky version is released, qcow images are usually published later. Hence the url for a specific rocky linux won't work. As a temporary solution, the latest qcow image is used for a major version.

CopilotAI review requested due to automatic review settings June 30, 2026 14:36
Similar to current implementation for the lts kernels, except for 2 changes:
1. source tree branch changes for rlc when a new version is released, hence
we cannot lock a specific version in kernels.yaml file. Instead a pattern
is used. And when kt checkout is used, the latest branch that matches the
pattern is found and used.
2. if a new minor rocky version is released, qcow images are usually
published later. Hence the url for a specific rocky linux won't work.
As a temporary solution, the latest qcow image is used for a major version.
Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
@roxanan1996
roxanan1996force-pushed the {rnicolescu}_kt_add_rlc_checkout_and_vm branch from ea54409 to 070ff15CompareJune 30, 2026 14:40

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces support for RLC kernel workspaces by adding a kernel “type” concept, selecting the newest matching source-tree branch at checkout time, and switching VM image download base URLs to use Rocky’s public mirror for RLC.

Changes:

  • Add kernel_type metadata to kernel definitions and introduce a KernelType enum.
  • For RLC kernels, resolve src_tree_branch patterns (with X.Y placeholders) to the newest matching remote branch during workspace load.
  • Use a different Rocky Linux base URL for RLC VM qcow2 downloads.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
FileDescription
kt/ktlib/vm.pySelects VM image base URL depending on kernel type.
kt/ktlib/util.pyAdds an RLC-specific Rocky download base URL constant.
kt/ktlib/kernels.pyIntroduces KernelType and adds kernel_type to KernelInfo.
kt/ktlib/kernel_workspace.pyAdds RLC-aware branch resolution and worktree update behavior.
kt/data/kernels.yamlAdds kernel_type fields and new RLC kernel entries with branch patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadkt/ktlib/kernels.py
Comment on lines 1 to 4
import logging
from dataclasses import dataclass
from enum import StrEnum, auto

Comment threadkt/ktlib/kernels.py
Comment threadkt/ktlib/kernel_workspace.py
Comment threadkt/ktlib/kernel_workspace.py
Comment threadkt/ktlib/kernel_workspace.py
Comment threadkt/ktlib/vm.py
CopilotAI review requested due to automatic review settings June 30, 2026 14:42

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

Comment threadkt/ktlib/kernels.py
Comment threadkt/ktlib/vm.py
Comment threadkt/ktlib/kernel_workspace.py
Comment threadkt/ktlib/kernel_workspace.py
Comment threadkt/ktlib/kernel_workspace.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@roxanan1996