Uh oh!
There was an error while loading. Please reload this page.
kt: Introduce kt checkout/vm for rlc kernels - #78
Conversation
Similar to current implementation for the lts kernels, except for 2 changes: 1. source tree branch changes for rlc when a new version is released, hence we cannot lock a specific version in kernels.yaml file. Instead a pattern is used. And when kt checkout is used, the latest branch that matches the pattern is found and used. 2. if a new minor rocky version is released, qcow images are usually published later. Hence the url for a specific rocky linux won't work. As a temporary solution, the latest qcow image is used for a major version. Signed-off-by: Roxana Nicolescu <rnicolescu@ciq.com>
ea54409 to
070ff15CompareThere was a problem hiding this comment.
Pull request overview
Introduces support for RLC kernel workspaces by adding a kernel “type” concept, selecting the newest matching source-tree branch at checkout time, and switching VM image download base URLs to use Rocky’s public mirror for RLC.
Changes:
- Add
kernel_typemetadata to kernel definitions and introduce aKernelTypeenum. - For RLC kernels, resolve
src_tree_branchpatterns (withX.Yplaceholders) to the newest matching remote branch during workspace load. - Use a different Rocky Linux base URL for RLC VM qcow2 downloads.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| kt/ktlib/vm.py | Selects VM image base URL depending on kernel type. |
| kt/ktlib/util.py | Adds an RLC-specific Rocky download base URL constant. |
| kt/ktlib/kernels.py | Introduces KernelType and adds kernel_type to KernelInfo. |
| kt/ktlib/kernel_workspace.py | Adds RLC-aware branch resolution and worktree update behavior. |
| kt/data/kernels.yaml | Adds kernel_type fields and new RLC kernel entries with branch patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import logging | ||
| from dataclasses import dataclass | ||
| from enum import StrEnum, auto | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Similar to current implementation for the lts kernels, except for 2 changes: