Uh oh!
There was an error while loading. Please reload this page.
Add Ready-screen battery indicator - #56
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The Ready screen did not expose any power status. The Waveshare board provides a divided
VSYSreading on GP29 and an RP2040 VBUS status bit, but USB power masks the isolated battery voltage. The implementation therefore reports battery-only voltage honestly and treats the initial full fill under USB as powered status rather than an exact cell measurement.User impact
Drivers can see approximate remaining charge before starting a session and immediately recognize external power from the charging bolt. The 35×16 px icon is centered at the top of the circular display with a 12 px gap before
Ready, preserving all existing settings and instructions.Validation
python -m unittest discover -s tests -v— 82 tests passedCloses#55