Uh oh!
There was an error while loading. Please reload this page.
Add configurable hardware startup splash - #58
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
params.json, defaulting to two secondsBOOT_DELAY_SECvalue to the first-screen durationWhy
The timer previously moved directly from the artwork splash to Ready and its single startup delay was not clearly named for a multi-screen sequence. The new information screen makes the installed hardware and runtime visible during boot. Physical testing also showed that dark text on the original background lacked sufficient contrast, so the final design uses white on black.
Impact
Existing configurations remain compatible.
BOOT_DELAY_SECis accepted as the first-screen duration, while the second screen defaults to two seconds. New configurations useSTARTUP_SPLASH_DURATION_SECandHARDWARE_SPLASH_DURATION_SEC.Validation
python -m unittest discover -s tests -v— 89 tests passedgit diff --checkpassedCloses#57