Skip to content

test: add React Native scene notification E2E (MBL-2303) - #643

Merged
Shahroz16 merged 15 commits into
mainfrom
codex/mbl-2234-rn-maestro-e2e
Aug 26, 2026
Merged

test: add React Native scene notification E2E (MBL-2303)#643
Shahroz16 merged 15 commits into
mainfrom
codex/mbl-2234-rn-maestro-e2e

Conversation

@Shahroz16

@Shahroz16Shahroz16 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • generate a React Native 0.88 UIScene host against the exact wrapper under test
  • tap real simulator notifications from terminated and warm app states with Maestro
  • assert each exact destination reaches React Native Linking
  • run nightly/manual on the Xcode 27 runner, plus pull-request validation when the E2E harness changes

The runner waits for Maestro to reach the Home screen before injecting each notification, so slower hosted startup cannot race the banner. No app-side test hook or workspace credential is added.

Validation

  • local Xcode 26.6 / iOS 26.5 clean host build passed
  • terminated notification tap passed
  • warm notification tap passed
  • ESLint, TypeScript, Jest, shell/Ruby/YAML/JSON syntax, and actionlint passed; actionlint only reports the repository custom xcode-27 runner label

This validates simulator presentation, tap handling, native buffering, and client routing. It does not claim real APNs/FCM token registration or Customer.io backend sent/delivered/opened evidence.

@Shahroz16
Shahroz16 requested a review from a team as a code ownerAugust 25, 2026 14:59
@github-actions

github-actionsBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • Android APN: 643.15.0 (29796293)
  • iOS APN: 643.15.0 (29796293)

Comment thread.maestro/run_scene_push.sh
@Shahroz16
Shahroz16force-pushed the codex/mbl-2234-rn-maestro-e2e branch 2 times, most recently from 788bc6c to 8d89134CompareAugust 25, 2026 16:03

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 98783b2. Configure here.

Comment thread.maestro/run_scene_push.sh
@Shahroz16Shahroz16 changed the title test: add React Native scene notification E2E (MBL-2234)test: add React Native scene notification E2E (MBL-2303)Aug 26, 2026
Base automatically changed from codex/mbl-2234-react-native-scene-deep-links to mainAugust 26, 2026 04:56
@Shahroz16
Shahroz16force-pushed the codex/mbl-2234-rn-maestro-e2e branch from 27abe03 to 98b8f9cCompareAugust 26, 2026 05:04

@mrehan27mrehan27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The design is sound and the cold flow is genuinely discriminating — terminating the app before the tap means a terminated-tap really does exercise the buffer-until-JS-ready path, so this guards the feature rather than just reaching the destination.

The comments below are all the same theme: the hardening that landed in customerio/customerio-flutter#400 hasn't been carried over to this lane. None of it blocks — the lane is green and the coverage is real — but the pinning one is worth doing before merge.

Comment thread.github/workflows/react-native-scene-e2e.yml Outdated
Comment thread.github/workflows/react-native-scene-e2e.yml Outdated
Comment thread.github/workflows/react-native-scene-e2e.yml
Comment thread.maestro/scene_push_prepare.yaml
Comment thread.maestro/run_scene_push.sh Outdated
Comment thread.maestro/scene_push_open.yaml Outdated
@Shahroz16
Shahroz16 merged commit 04c8357 into mainAug 26, 2026
11 checks passed
@Shahroz16
Shahroz16 deleted the codex/mbl-2234-rn-maestro-e2e branch August 26, 2026 20:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Shahroz16@mrehan27