Uh oh!
There was an error while loading. Please reload this page.
Feat/rescan height - #1382
Draft
sneurlax wants to merge 20 commits into
Draft
Conversation
Co-Authored-By: detherminal <76167420+detherminal@users.noreply.github.com>
these shouldn't exist/happen, but do/can
The prior merge commit introduced two copies of _parseWalletUri: one without dash normalization (from feat/restore-cryptonote) and one with (from feat/monero-uri). Keep only the correct version -- the one that normalises dashes in URI schemes before parsing -- matching the implementation already present on the vacay branch so the two branches merge cleanly.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## staging #1382 +/- ##
===========================================
+ Coverage 4.84% 13.11% +8.27%
===========================================
Files 1092 424 -668 Lines 109141 35637 -73504 ===========================================
- Hits 5283 4675 -608 + Misses 103858 30962 -72896 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.