Uh oh!
There was an error while loading. Please reload this page.
fix(docs): correct Flutter version, Rust toolchains, Ubuntu 24.04 meson install, add rsync - #1400
fix(docs): correct Flutter version, Rust toolchains, Ubuntu 24.04 meson install, add rsync#1400xrviv wants to merge 1 commit into
Conversation
77ad505 to
d0fa549Compare…l, add rsync - Flutter: 3.38.5 → 3.38.1 (all platforms; confirmed by libflutter.so identity match during reproducible build verification) - Rust: add 1.71.0 to all rustup install lines; required by crypto_plugins/frostdart/scripts/linux/build_all.sh which hardcodes cargo +1.71.0 - Ubuntu 24.04 meson: replace pipx with python3-venv approach; pipx cannot install library-only packages (markupsafe, jinja2, etc.) and will fail; setuptools added because Python 3.12 removed distutils which meson needs for GObject introspection - Linux desktop deps: add rsync; required by crypto_plugins/flutter_libmwc/scripts/linux/build_all.sh Fixes found during WalletScrutiny reproducible build verification (issue cypherstack#1399). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
d0fa549 to
b8f7e4cCompareThere was a problem hiding this comment.
The macOS 1.71.0 addition is right, frostdart's own CI does install 1.71.0 on macOS. But installing it alone isn't enough: crypto_plugins/frostdart/scripts/macos/build_macos.dart calls cargo lipo with no toolchain override, so the local build still uses whatever rustup default is (1.89.0 per these docs). The upstream CI works around this by setting 1.71.0 as the active toolchain before invoking cargo. The local script would need cargo +1.71.0 lipo ... to actually match. That's a pre-existing issue in the submodule script, not introduced here, worth a follow-up on the frostdart side.
Everything else looks good. Thanks for the thorough investigation.
Summary
Corrections to
docs/building.mdfound during WalletScrutiny reproducible build verification of Stack Wallet v2.4.4 (see issue #1399).3.38.5→3.38.1on all platforms (Linux, macOS, Windows). Confirmed bylibflutter.soidentity match against the official v2.4.4 binary.rustup installlines.crypto_plugins/frostdart/scripts/linux/build_all.shhardcodescargo +1.71.0; without it, frostdart fails to compile on all platforms.pipxwith apython3-venvapproach.pipxcannot install library-only packages (markupsafe,jinja2, etc.) and will exit with an error on Ubuntu 24.04.setuptoolsis added because Python 3.12 removeddistutils, which meson requires for the libsecret GObject introspection step.rsync: Added to Linux desktop deps.crypto_plugins/flutter_libmwc/scripts/linux/build_all.shusesrsyncto copy source into the build directory before runningcargo; without it the build fails immediately.Test plan
flutter --versionreports3.38.1after following updated Flutter install stepcargo +1.71.0 --versionworks after following updated rustup install stepmeson --versionreports0.64.1after following updated Ubuntu 24.04 meson install stepscripts/linux/build_app.sh -p linuxcompletes without rsync error🤖 Generated with Claude Code