Skip to content

Monero and Firo fix - #5

Merged
ryleedavis merged 36 commits into
mainfrom
staging
Aug 30, 2022
Merged

Monero and Firo fix#5
ryleedavis merged 36 commits into
mainfrom
staging

Conversation

@msalazarm

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter

codecov-commenter commented Aug 28, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@65f039e). Click here to learn what that means.
The diff coverage is n/a.

@@ Coverage Diff @@## main #5 +/- ##
=======================================
Coverage ? 42.54% =======================================
Files ? 100 Lines ? 10842 Branches ? 0 =======================================
Hits ? 4613 Misses ? 6229 Partials ? 0 

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

rehrar
rehrar previously approved these changes Aug 28, 2022
julian-CStack
julian-CStack previously approved these changes Aug 29, 2022
julian-CStack
julian-CStack previously approved these changes Aug 29, 2022
julian-CStack
julian-CStack previously approved these changes Aug 29, 2022
@ryleedavis
ryleedavis merged commit bd4ce2c into mainAug 30, 2022
ryleedavis added a commit that referenced this pull request Aug 30, 2022
Merge pull request #5 from cypherstack/staging
sneurlax added a commit that referenced this pull request Apr 25, 2024
hard to test, as I cannot claim/generate nor detect a previously-claimed/generated nym over Tor due to
```
flutter: Log: [Info][2024-04-25 20:28:22.609Z]: HTTP.post() rethrew: Exception: Command handling failed. With error: serverError
flutter: #0 SocksSocket._handleCommandResponse (package:socks5_proxy/src/client/socks_client.dart:196:7)
flutter: <asynchronous suspension>
flutter: #1 SocksSocket.initialize (package:socks5_proxy/src/client/socks_client.dart:74:22)
flutter: <asynchronous suspension>
flutter: #2 SocksTCPClient.connect (package:socks5_proxy/src/client/socks_tcp_client.dart:70:20)
flutter: <asynchronous suspension>
flutter: #3 SocksTCPClient.assignToHttpClientWithSecureOptions.<anonymous closure> (package:socks5_proxy/src/client/socks_tcp_client.dart:46:40)
flutter: <asynchronous suspension>
flutter: #4 _ConnectionTarget.connect.<anonymous closure> (dart:_http/http_impl.dart:2490:32)
flutter: <asynchronous suspension>
flutter: #5 _HttpClient._openUrl.<anonymous closure> (dart:_http/http_impl.dart:2787:15)
flutter: <asynchronous suspension>
flutter: #6 HTTP.post (package:stackwallet/networking/http.dart:85:41)
flutter: <asynchronous suspension>
flutter: #7 PaynymIsApi._post (package:stackwallet/utilities/paynym_is_api.dart:54:22)
flutter: <asynchronous suspension>
flutter: #8 PaynymIsApi.nym (package:stackwallet/utilities/paynym_is_api.dart:267:22)
flutter: <asynchronous suspension>
flutter: #9 Wallet.refresh (package:stackwallet/wallets/wallet/wallet.dart:511:21)
flutter: <asynchronous suspension>
```
sneurlax added a commit that referenced this pull request Aug 14, 2025
WIP, polyseed restoration test throws:
```
flutter: ERROR ┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
flutter: ERROR │ 2025-08-14 20:21:20.986
flutter: ERROR ├┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄┄
flutter: ERROR │ Monero wallet test suite failed: Exception: file already exists "~/.stackwallet/wallets/monero/polyseed_test_2529"
flutter: ERROR │ #0 checkWalletStatus (package:cs_monero/src/ffi_bindings/monero_wallet_bindings.dart:18:3)
flutter: ERROR │ #1 MoneroWallet.restoreWalletFromSeed (package:cs_monero/src/wallets/monero_wallet.dart:241:13)
flutter: ERROR │ <asynchronous suspension>
flutter: ERROR │ #2 MoneroWalletTestSuite._testPolyseedRestoration (package:stackwallet/services/testing/test_suites/monero_wallet_test_suite.dart:194:16)
flutter: ERROR │ <asynchronous suspension>
flutter: ERROR │ #3 MoneroWalletTestSuite.runTests (package:stackwallet/services/testing/test_suites/monero_wallet_test_suite.dart:52:7)
flutter: ERROR │ <asynchronous suspension>
flutter: ERROR │ #4 Future.timeout.<anonymous closure> (dart:async/future_impl.dart:1043:7)
flutter: ERROR │ <asynchronous suspension>
flutter: ERROR │ #5 TestingService.runTestSuite (package:stackwallet/services/testing/testing_service.dart:88:22)
flutter: ERROR │ <asynchronous suspension>
flutter: ERROR │ #6 TestingService.runAllTests (package:stackwallet/services/testing/testing_service.dart:65:9)
flutter: ERROR │ <asynchronous suspension>
flutter: ERROR │
flutter: ERROR └───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
```
bitfinitechain added a commit to bitfinitechain/bitfinite-wallet that referenced this pull request Jul 9, 2026
…loader, polished theme-aware personas
- Test connection always failed (and thus blocked node switching): the check
sent a param-less server.version, which BFX electrs rejects. Send the same
[client, [1.4,1.5]] params as the live client → test passes → the
test-gated "switch node" flow works again. (#1, cypherstack#3)
- Remove the duplicate/confusingly-named "BitFinite (seed-3)" seed node and
delete it from existing DBs; the failover is now just "BitFinite Electrum 2"
(electrum2.bitfinitechain.org). (cypherstack#2)
- Unify the loader: the "Loading wallets…" overlay used a Material circle while
app-init showed the duo. New shared DuoLoader widget; CustomLoadingOverlay now
uses it → one duo loader everywhere. (cypherstack#5)
- Refresh Miso + Ollie personas with the polished (smoother) art and make them
theme-aware (light/dark variants) on the privacy screen + home header. (cypherstack#4)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@msalazarm@codecov-commenter@rehrar@julian-CStack@ryleedavis