ENG-836 - Drukbox image ships the docker CLI - #6
Merged
Merged
Conversation
czpython
marked this pull request as ready for review
August 9, 2026 10:21
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime image now carries the Docker CLI: a pinned
docker:29.6.2-clistage contributes/usr/local/bin/dockeronly — nodockerd, no daemon — and CI verifies the client runs underappuser.The API-test job now exercises the built image instead of a host-run uvicorn: it builds
drukbox:api-test, launches it with host networking and the runner's Docker socket (matching socket GID), runs migrations in-container, and keeps the always-run cleanup plus managed-by=drukbox assertions. The provider-generic API test additionally requires non-emptyknown_hostsafter active creation.docs/deploy.mdgains a single portable run command for the published image (Linux and macOS), the host-loopback explanation, maintenance-container requirements, theDOCKER_HOSTescape hatch, and scope/security warnings.