Uh oh!
There was an error while loading. Please reload this page.
Abort the release when any step fails - #66
Merged
Conversation
CLI::UI::Spinner.spin reports a failed task but returns instead of raising, so a failed push cascaded into the formula step publishing a tag that never reached GitHub (v0.2.73) with an empty sha256, breaking brew installs until hand-fixed. Each step now aborts the release on failure. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
JPDuchesne added a commit
that referenced
this pull request
Jul 31, 2026
32e4836 Merge pull request #72 from d3mlabs/jpd/ci-rename 882f47b Rename test.yml to ci.yml and split typecheck into its own job a2dc24c Merge pull request #69 from d3mlabs/jpd/headless-deps-provisioning 7272267 Hoist lazy requires to file tops per top-level-requires 2e53f69 Cover CommandRunner's provisioning delegation to ShadowenvRuby.ensure! dc2942b Provision the shadowenv Ruby in install-deps and run bundler under it 32c59cd Merge pull request #68 from d3mlabs/jpd/caller-pull-request-review 3e59620 Subscribe the ai-flow caller to pull_request_review (submitted) b0822e9 Merge pull request #67 from d3mlabs/ai/58-learnings-index-format-learnings-index-m 7939c97 ai-flow /build: Learnings index format (learnings-index.mdc) + dev repo seeds (RSpock invariant line, gitlink-exclusion learning, architecture section) + capture-learning skill 91ab491 Merge pull request #66 from d3mlabs/jpd/release-abort-on-failure 42376f3 Abort the release when any step fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI::UI::Spinner.spinswallows the block's exception and only reports it, sobin/release.rbkept going after a failed step — during v0.2.73 a rejectedgit pushstill led to the Homebrew formula being pushed with a nonexistent tag URL and an emptysha256, breakingbrew install devuntil hand-fixed.stephelper that wraps each spinner and aborts the release the moment a step fails (verifiedSpinner.spinreturnsfalsewhen the block raises).Test plan
bin/**/*is rubocop-excluded; script syntax verified locally)dev releaseexercises the happy pathMade with Cursor