Composition fails if reference field is undefined

[jimlambie]

Expected behaviour

A document with reference fields should return fully composed regardless of whether optional fields have been completed or not.

Actual behaviour

If a reference field does not hold a value, the composition process exits prematurely and a non-composed document is returned.

Steps to reproduce the problem

Create a collection with at least one reference field. Add documents to the collection which have one or more reference fields undefined. Perform a GET request to the collection - all reference fields should hold original ID values only, i.e. no composition has been performed.

Package details

@dadi/api@3.0.0
@dadi/api-mongodb@3.5.0

[jimlambie]

An update to this. In general, composition works if a reference field doesn't exist in a document. This works fine when returning a single document. However when returning a result set containing multiple documents, the set of reference fields to attempt composition for is a merged array of reference field names extracted from the full set of documents.