Skip to content

Add Tikhonov Regularization - #98

Open
ErickHernandezGutierrez wants to merge 19 commits into
daducci:masterfrom
ErickHernandezGutierrez:regtikhonov
Open

Add Tikhonov Regularization#98
ErickHernandezGutierrez wants to merge 19 commits into
daducci:masterfrom
ErickHernandezGutierrez:regtikhonov

Conversation

@ErickHernandezGutierrez

@ErickHernandezGutierrezErickHernandezGutierrez commented Feb 16, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@MarioOcampo

MarioOcampo commented Feb 17, 2021

Copy link
Copy Markdown
Contributor

Hello @ErickHernandezGutierrez,
thanks for the PR. Can I ask you to change the line breaks of the files, they should be LF.

daducci
daducci requested changes Feb 24, 2021
View reviewed changes
Comment threadCHANGELOG.md
Comment threadcommit/core.pyx Outdated
Comment threadcommit/core.pyx Outdated
Comment threadcommit/core.pyx Outdated
Comment threadcommit/core.pyx Outdated
Comment threadcommit/core.pyx Outdated
Comment threadcommit/operator/operator.pyx Outdated
Comment threadcommit/core.pyx Outdated
Comment threadcommit/operator/operator_noLUT.c Outdated
Comment threadcommit/operator/operator_noLUT.c Outdated
return;
}

void COMMIT_L(

@daduccidaducciFeb 24, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all these functions are empty if no LUT is selected? The regularization should be enforced in any case, no?

@ErickHernandezGutierrezErickHernandezGutierrezFeb 25, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is in the TODO to enable the Tikhonov regularization when no LUT is selected.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daduccidaduccidaducci requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ErickHernandezGutierrez@MarioOcampo@daducci