Sourcery refactored master branch - #2
Merged
Merged
Conversation
| def get_my_passwords(passbolt_obj): | ||
| result = list() | ||
| result = [] |
Author
There was a problem hiding this comment.
Function get_my_passwords refactored with the following changes:
- Replace
list()with[](list-literal) - Replace call to format with f-string (
use-fstring-for-formatting)
Comment on lines
-27
to
+26
| result = list() | ||
| result = [] |
Author
There was a problem hiding this comment.
Function get_passwords_basic refactored with the following changes:
- Replace
list()with[](list-literal) - Replace call to format with f-string (
use-fstring-for-formatting)
| if return_response_object: | ||
| return r | ||
| return r.json() | ||
| return r if return_response_object else r.json() |
Author
There was a problem hiding this comment.
Function APIClient.get refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-172
to
+170
| if return_response_object: | ||
| return r | ||
| return r.json() | ||
| return r if return_response_object else r.json() |
Author
There was a problem hiding this comment.
Function APIClient.put refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-183
to
+179
| if return_response_object: | ||
| return r | ||
| return r.json() | ||
| return r if return_response_object else r.json() |
Author
There was a problem hiding this comment.
Function APIClient.post refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-250
to
+247
| url_params = "?" + url_params | ||
| response = self.get("/resources.json" + url_params) | ||
| url_params = f"?{url_params}" | ||
| response = self.get(f"/resources.json{url_params}") | ||
| assert "body" in response.keys(), f"Key 'body' not found in response keys: {response.keys()}" | ||
| resources = response["body"] | ||
| for resource in resources: | ||
| yield resource | ||
| yield from response["body"] |
Author
There was a problem hiding this comment.
Function PassboltAPI.iterate_resources refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Inline variable that is immediately yielded (
inline-immediately-yielded-variable) - Replace yield inside for loop with yield from (
yield-from)
Comment on lines
-264
to
+257
| url_params = "?" + url_params | ||
| response = self.get("/folders.json" + url_params) | ||
| url_params = f"?{url_params}" | ||
| response = self.get(f"/folders.json{url_params}") |
Author
There was a problem hiding this comment.
Function PassboltAPI.list_resources refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-295
to
+287
| response = self.get(f"/users.json", params=params) | ||
| response = self.get("/users.json", params=params) |
Author
There was a problem hiding this comment.
Function PassboltAPI.list_users refactored with the following changes:
- Replace f-string with no interpolated values with string (
remove-redundant-fstring)
Comment on lines
-468
to
+464
| r = self.put(f"/resources/{resource_id}.json", payload, return_response_object=True) | ||
| return r | ||
| return self.put( | ||
| f"/resources/{resource_id}.json", | ||
| payload, | ||
| return_response_object=True, | ||
| ) |
Author
There was a problem hiding this comment.
Function PassboltAPI.update_resource refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!