Uh oh!
There was an error while loading. Please reload this page.
uninstall script in macos - #695
Merged
Merged
Conversation
pablomendezroyo
approved these changes
Mar 2, 2026
29 tasks
pablomendezroyo
merged commit Mar 2, 2026
a511f2c
into
pablo/install-script-macos
6 of 7 checks passed
Uh oh!
There was an error while loading. Please reload this page.
pablomendezroyo added a commit
that referenced
this pull request
Mar 9, 2026
* Enhance macOS compatibility in installation script - Added checks to ensure the script is executed, not sourced. - Improved OS detection and handling for macOS and Linux. - Updated directory paths for macOS. - Introduced cross-platform helper functions for downloading files and modifying files. - Added functionality to patch the .dappnode_profile for macOS compatibility. - Enhanced user shell configuration to source the profile correctly. - Cleaned up rc.local for Linux installations. - Improved logging and user feedback during installation. * Add macOS support for installation scripts and update DAppNode core start function * Normalize component names to lowercase in download URL and file paths * Update macOS test script to install Docker using Homebrew * Normalize component names to lowercase in Docker image loading logic * Remove macOS test scripts from workflow configuration * Update IPFS endpoint and enhance logging in installation script * Refactor logging in installation script to remove color output and improve readability * uninstall script in macos (#695) * uninstall script in macos * comment reexec under bash * comment * remove colors logic --------- Co-authored-by: pablomendezroyo <41727368+pablomendezroyo@users.noreply.github.com> * Enhance installation script with improved error handling, logging, and CLI wrappers for VPN commands * Remove core CLI wrappers from installation script to streamline execution * Add macOS-specific environment variable injection for dappmanager compose * Fix DISABLE_HOST_SCRIPTS environment variable handling in macOS patch function * Initialize DNCORE_COMPOSE_ARGS array to prevent unbound variable errors * Refactor macOS patch function to handle environment variable insertion with temporary file for compatibility * Increase sleep duration to 30 seconds for VPN initialization in installation script * Implement wait_for_internal_ip function to ensure dappmanager publishes INTERNAL_IP before proceeding * Add macOS server detection and adjust package selection for always-on Macs * Add patch for macOS non-server to use remote IPFS services in maindb.json * Enhance wait_for_internal_ip function to check for HOSTNAME alongside INTERNAL_IP and improve error messaging; add wait for maindb.json file existence in macOS non-server patch function * Remove macOS non-server patch for remote IPFS services from installation script * Remove default PROFILE_BRANCH assignment from installation script * Add support for minimal installation mode and enhance argument parsing in installer script * Increase wait time for VPN initialization in installer script * Add function to print VPN access credentials after core startup * Refactor Linux setup steps to conditionally execute based on MINIMAL mode * Add support for Notifications and Premium packages in installation scripts (#696) * Add local profile path argument to DAppNode installation script * Add support for macOS in VPN access credential retrieval * Add support for custom package selection in installation script * Add interactive setup wizard to installation script * Add conditional output for VPN credentials based on selected packages * Remove interactive mode support from installation script * Add support for lite installation mode in the installation script * Refactor installation script by removing macOS-specific checks and unused functions * Improve Docker prerequisite checks in installation script * Remove outdated comment regarding patch_compose_paths function in installation script --------- Co-authored-by: Marc Font <36164126+Marketen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
dappnode_uninstall.shcompatible in macos:DAPPNODE_DIRin linux & mac like it was defined in the install scriptcolor_echofunction). no ANSI on macOS to avoid \e issuesNice to have:
source dappnode_uninstall.sh(or . dappnode_uninstall.sh), therm -rf "${DAPPNODE_DIR}"andexit 1would run in their current shell. The exit would close their terminal. The source guard prevents that.script output: