Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 31, 2024. It is now read-only.
add mevboostmetric - #23
Open
darkda567 wants to merge 2 commits into
Open
Conversation
Marketen
suggested changes
Nov 10, 2023
Contributor
There was a problem hiding this comment.
this is unecessary, all the dependencies needed for "stakers-metrics" should be inside ./stakers-metrics" directory. There is already a package.json there, feel free to add whatever dependencies you need in that file
Contributor
There was a problem hiding this comment.
this is unnecessary, this project is built with yarn instead of npm, and all dependencies should be installed inside their respective directories, not in the base directory.
Contributor
There was a problem hiding this comment.
same as the other 2 related comments, there is already a yarn.lock file inside ./stakers-metrics dir
| } | ||
| async function collectMevBoostMetric(network: typeof networks[number]) { | ||
| console.log(`Collecting MEV Boost metric for network: ${network}`); |
Contributor
There was a problem hiding this comment.
2 things:
- we use
loggerinstead of console for logging purposes in this project - there is no need to log anything while collecting the metric if there are no errors
| const envKey = `_DAPPNODE_GLOBAL_MEVBOOST_${network.toUpperCase()}`; | ||
| const mevBoostValue = process.env[envKey]; | ||
| logger.info(`MEV Boost value for network ${network}: ${mevBoostValue}`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new metric that indicates the mevboost value of each network.